Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target=" blank" #168

Merged

Conversation

sevenshamrocks
Copy link
Contributor

@sevenshamrocks sevenshamrocks commented Oct 8, 2024

Adds target="_blank" text to links in HTML when option is selected in sidebar. This should be the fourth pull request.

Addresses issue #137 & #154

sevenshamrocks and others added 11 commits October 7, 2024 11:53
Added center/right alignment handling.
Added center/right alignment handling for headings. Adds text-align to header tag.
Moves closing of styles to the beginning of the loop to close styles before opening new ones. Moves opening superscript later in the loop with the other attributes.
Updated version info.
Added support for Markdown checkboxes.
Add option for target="_blank" to menu
Adds target="_blank" to links in HTML if target="_blank" is selected in the sidebar.
Updated version number.
Add a comment that points to glyph type enum doc in case this ever breaks.
@evbacher evbacher merged commit ab4ac21 into evbacher:dev-main-1.0β38-base Oct 9, 2024
evbacher added a commit that referenced this pull request Oct 12, 2024
* Center/right alignment (#165)

* Update gdc.gs

Added center/right alignment handling.

* Update html.gs

Added center/right alignment handling for headings. Adds text-align to header tag.

* Update gdc.gs

* Update gdc.gs

Tweaked if statement to allow for Markdown right-alignment.

* Superscript fix (#166)

* Update gdc.gs

Added center/right alignment handling.

* Update html.gs

Added center/right alignment handling for headings. Adds text-align to header tag.

* Update gdc.gs

* Update gdc.gs

Moves closing of styles to the beginning of the loop to close styles before opening new ones. Moves opening superscript later in the loop with the other attributes.

* Update gdc.gs

Updated version info.

---------

Co-authored-by: evbacher <[email protected]>

* Add markdown checkboxes (#167)

* Update gdc.gs

Added center/right alignment handling.

* Update html.gs

Added center/right alignment handling for headings. Adds text-align to header tag.

* Update gdc.gs

* Update gdc.gs

Moves closing of styles to the beginning of the loop to close styles before opening new ones. Moves opening superscript later in the loop with the other attributes.

* Update gdc.gs

Updated version info.

* Update gdc.gs

Added support for Markdown checkboxes.

---------

Co-authored-by: evbacher <[email protected]>

* Target=" blank" (#168)

* Update gdc.gs

Added center/right alignment handling.

* Update html.gs

Added center/right alignment handling for headings. Adds text-align to header tag.

* Update gdc.gs

* Update gdc.gs

Moves closing of styles to the beginning of the loop to close styles before opening new ones. Moves opening superscript later in the loop with the other attributes.

* Update gdc.gs

Updated version info.

* Update gdc.gs

Added support for Markdown checkboxes.

* Update sidebar.html

Add option for target="_blank" to menu

* Update gdc.gs

Adds target="_blank" to links in HTML if target="_blank" is selected in the sidebar.

* Update gdc.gs

Updated version number.

* Update gdc.gs

Add a comment that points to glyph type enum doc in case this ever breaks.

---------

Co-authored-by: evbacher <[email protected]>

* Close <li> tags (#169)

* Update gdc.gs

Added center/right alignment handling.

* Update html.gs

Added center/right alignment handling for headings. Adds text-align to header tag.

* Update gdc.gs

* Update gdc.gs

Moves closing of styles to the beginning of the loop to close styles before opening new ones. Moves opening superscript later in the loop with the other attributes.

* Update gdc.gs

Updated version info.

* Update gdc.gs

Added support for Markdown checkboxes.

* Update sidebar.html

Add option for target="_blank" to menu

* Update gdc.gs

Adds target="_blank" to links in HTML if target="_blank" is selected in the sidebar.

* Update gdc.gs

Updated version number.

* Update gdc.gs

Added list handling to properly close li tags. This makes sure they close at the end of the paragraph.

* Update html.gs

Added extra handling to close li tags. In short, they need to be closed right before opening a new li tag. Otherwise, they should be closed before closing out the whole list.

* Update gdc.gs

Updated files changed.

---------

Co-authored-by: evbacher <[email protected]>

* Remove target="_blank" for now (#171)

* Update gdc.gs

Remove target="_blank" option for now.

* Update sidebar.html

Remove target="_blank" option for now.

* Update appsscript.json 1.0B38 version

Update oauthScopes.

---------

Co-authored-by: sevenshamrocks <[email protected]>
evbacher added a commit that referenced this pull request Oct 13, 2024
* Center/right alignment (#165)

* Update gdc.gs

Added center/right alignment handling.

* Update html.gs

Added center/right alignment handling for headings. Adds text-align to header tag.

* Update gdc.gs

* Update gdc.gs

Tweaked if statement to allow for Markdown right-alignment.

* Superscript fix (#166)

* Update gdc.gs

Added center/right alignment handling.

* Update html.gs

Added center/right alignment handling for headings. Adds text-align to header tag.

* Update gdc.gs

* Update gdc.gs

Moves closing of styles to the beginning of the loop to close styles before opening new ones. Moves opening superscript later in the loop with the other attributes.

* Update gdc.gs

Updated version info.

---------

Co-authored-by: evbacher <[email protected]>

* Add markdown checkboxes (#167)

* Update gdc.gs

Added center/right alignment handling.

* Update html.gs

Added center/right alignment handling for headings. Adds text-align to header tag.

* Update gdc.gs

* Update gdc.gs

Moves closing of styles to the beginning of the loop to close styles before opening new ones. Moves opening superscript later in the loop with the other attributes.

* Update gdc.gs

Updated version info.

* Update gdc.gs

Added support for Markdown checkboxes.

---------

Co-authored-by: evbacher <[email protected]>

* Target=" blank" (#168)

* Update gdc.gs

Added center/right alignment handling.

* Update html.gs

Added center/right alignment handling for headings. Adds text-align to header tag.

* Update gdc.gs

* Update gdc.gs

Moves closing of styles to the beginning of the loop to close styles before opening new ones. Moves opening superscript later in the loop with the other attributes.

* Update gdc.gs

Updated version info.

* Update gdc.gs

Added support for Markdown checkboxes.

* Update sidebar.html

Add option for target="_blank" to menu

* Update gdc.gs

Adds target="_blank" to links in HTML if target="_blank" is selected in the sidebar.

* Update gdc.gs

Updated version number.

* Update gdc.gs

Add a comment that points to glyph type enum doc in case this ever breaks.

---------

Co-authored-by: evbacher <[email protected]>

* Close <li> tags (#169)

* Update gdc.gs

Added center/right alignment handling.

* Update html.gs

Added center/right alignment handling for headings. Adds text-align to header tag.

* Update gdc.gs

* Update gdc.gs

Moves closing of styles to the beginning of the loop to close styles before opening new ones. Moves opening superscript later in the loop with the other attributes.

* Update gdc.gs

Updated version info.

* Update gdc.gs

Added support for Markdown checkboxes.

* Update sidebar.html

Add option for target="_blank" to menu

* Update gdc.gs

Adds target="_blank" to links in HTML if target="_blank" is selected in the sidebar.

* Update gdc.gs

Updated version number.

* Update gdc.gs

Added list handling to properly close li tags. This makes sure they close at the end of the paragraph.

* Update html.gs

Added extra handling to close li tags. In short, they need to be closed right before opening a new li tag. Otherwise, they should be closed before closing out the whole list.

* Update gdc.gs

Updated files changed.

---------

Co-authored-by: evbacher <[email protected]>

* Remove target="_blank" for now (#171)

* Update gdc.gs

Remove target="_blank" option for now.

* Update sidebar.html

Remove target="_blank" option for now.

* Update appsscript.json 1.0B38 version

Update oauthScopes.

* Add fix for closing mixed code spans.

See section where we close code.

---------

Co-authored-by: sevenshamrocks <[email protected]>
@sevenshamrocks sevenshamrocks deleted the Target="_blank" branch October 14, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants