-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target=" blank" #168
Merged
evbacher
merged 11 commits into
evbacher:dev-main-1.0β38-base
from
sevenshamrocks:Target="_blank"
Oct 9, 2024
The head ref may contain hidden characters: "Target=\"_blank\""
Merged
Target=" blank" #168
evbacher
merged 11 commits into
evbacher:dev-main-1.0β38-base
from
sevenshamrocks:Target="_blank"
Oct 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added center/right alignment handling.
Added center/right alignment handling for headings. Adds text-align to header tag.
Moves closing of styles to the beginning of the loop to close styles before opening new ones. Moves opening superscript later in the loop with the other attributes.
Updated version info.
Added support for Markdown checkboxes.
Add option for target="_blank" to menu
Adds target="_blank" to links in HTML if target="_blank" is selected in the sidebar.
Updated version number.
Add a comment that points to glyph type enum doc in case this ever breaks.
evbacher
added a commit
that referenced
this pull request
Oct 12, 2024
* Center/right alignment (#165) * Update gdc.gs Added center/right alignment handling. * Update html.gs Added center/right alignment handling for headings. Adds text-align to header tag. * Update gdc.gs * Update gdc.gs Tweaked if statement to allow for Markdown right-alignment. * Superscript fix (#166) * Update gdc.gs Added center/right alignment handling. * Update html.gs Added center/right alignment handling for headings. Adds text-align to header tag. * Update gdc.gs * Update gdc.gs Moves closing of styles to the beginning of the loop to close styles before opening new ones. Moves opening superscript later in the loop with the other attributes. * Update gdc.gs Updated version info. --------- Co-authored-by: evbacher <[email protected]> * Add markdown checkboxes (#167) * Update gdc.gs Added center/right alignment handling. * Update html.gs Added center/right alignment handling for headings. Adds text-align to header tag. * Update gdc.gs * Update gdc.gs Moves closing of styles to the beginning of the loop to close styles before opening new ones. Moves opening superscript later in the loop with the other attributes. * Update gdc.gs Updated version info. * Update gdc.gs Added support for Markdown checkboxes. --------- Co-authored-by: evbacher <[email protected]> * Target=" blank" (#168) * Update gdc.gs Added center/right alignment handling. * Update html.gs Added center/right alignment handling for headings. Adds text-align to header tag. * Update gdc.gs * Update gdc.gs Moves closing of styles to the beginning of the loop to close styles before opening new ones. Moves opening superscript later in the loop with the other attributes. * Update gdc.gs Updated version info. * Update gdc.gs Added support for Markdown checkboxes. * Update sidebar.html Add option for target="_blank" to menu * Update gdc.gs Adds target="_blank" to links in HTML if target="_blank" is selected in the sidebar. * Update gdc.gs Updated version number. * Update gdc.gs Add a comment that points to glyph type enum doc in case this ever breaks. --------- Co-authored-by: evbacher <[email protected]> * Close <li> tags (#169) * Update gdc.gs Added center/right alignment handling. * Update html.gs Added center/right alignment handling for headings. Adds text-align to header tag. * Update gdc.gs * Update gdc.gs Moves closing of styles to the beginning of the loop to close styles before opening new ones. Moves opening superscript later in the loop with the other attributes. * Update gdc.gs Updated version info. * Update gdc.gs Added support for Markdown checkboxes. * Update sidebar.html Add option for target="_blank" to menu * Update gdc.gs Adds target="_blank" to links in HTML if target="_blank" is selected in the sidebar. * Update gdc.gs Updated version number. * Update gdc.gs Added list handling to properly close li tags. This makes sure they close at the end of the paragraph. * Update html.gs Added extra handling to close li tags. In short, they need to be closed right before opening a new li tag. Otherwise, they should be closed before closing out the whole list. * Update gdc.gs Updated files changed. --------- Co-authored-by: evbacher <[email protected]> * Remove target="_blank" for now (#171) * Update gdc.gs Remove target="_blank" option for now. * Update sidebar.html Remove target="_blank" option for now. * Update appsscript.json 1.0B38 version Update oauthScopes. --------- Co-authored-by: sevenshamrocks <[email protected]>
evbacher
added a commit
that referenced
this pull request
Oct 13, 2024
* Center/right alignment (#165) * Update gdc.gs Added center/right alignment handling. * Update html.gs Added center/right alignment handling for headings. Adds text-align to header tag. * Update gdc.gs * Update gdc.gs Tweaked if statement to allow for Markdown right-alignment. * Superscript fix (#166) * Update gdc.gs Added center/right alignment handling. * Update html.gs Added center/right alignment handling for headings. Adds text-align to header tag. * Update gdc.gs * Update gdc.gs Moves closing of styles to the beginning of the loop to close styles before opening new ones. Moves opening superscript later in the loop with the other attributes. * Update gdc.gs Updated version info. --------- Co-authored-by: evbacher <[email protected]> * Add markdown checkboxes (#167) * Update gdc.gs Added center/right alignment handling. * Update html.gs Added center/right alignment handling for headings. Adds text-align to header tag. * Update gdc.gs * Update gdc.gs Moves closing of styles to the beginning of the loop to close styles before opening new ones. Moves opening superscript later in the loop with the other attributes. * Update gdc.gs Updated version info. * Update gdc.gs Added support for Markdown checkboxes. --------- Co-authored-by: evbacher <[email protected]> * Target=" blank" (#168) * Update gdc.gs Added center/right alignment handling. * Update html.gs Added center/right alignment handling for headings. Adds text-align to header tag. * Update gdc.gs * Update gdc.gs Moves closing of styles to the beginning of the loop to close styles before opening new ones. Moves opening superscript later in the loop with the other attributes. * Update gdc.gs Updated version info. * Update gdc.gs Added support for Markdown checkboxes. * Update sidebar.html Add option for target="_blank" to menu * Update gdc.gs Adds target="_blank" to links in HTML if target="_blank" is selected in the sidebar. * Update gdc.gs Updated version number. * Update gdc.gs Add a comment that points to glyph type enum doc in case this ever breaks. --------- Co-authored-by: evbacher <[email protected]> * Close <li> tags (#169) * Update gdc.gs Added center/right alignment handling. * Update html.gs Added center/right alignment handling for headings. Adds text-align to header tag. * Update gdc.gs * Update gdc.gs Moves closing of styles to the beginning of the loop to close styles before opening new ones. Moves opening superscript later in the loop with the other attributes. * Update gdc.gs Updated version info. * Update gdc.gs Added support for Markdown checkboxes. * Update sidebar.html Add option for target="_blank" to menu * Update gdc.gs Adds target="_blank" to links in HTML if target="_blank" is selected in the sidebar. * Update gdc.gs Updated version number. * Update gdc.gs Added list handling to properly close li tags. This makes sure they close at the end of the paragraph. * Update html.gs Added extra handling to close li tags. In short, they need to be closed right before opening a new li tag. Otherwise, they should be closed before closing out the whole list. * Update gdc.gs Updated files changed. --------- Co-authored-by: evbacher <[email protected]> * Remove target="_blank" for now (#171) * Update gdc.gs Remove target="_blank" option for now. * Update sidebar.html Remove target="_blank" option for now. * Update appsscript.json 1.0B38 version Update oauthScopes. * Add fix for closing mixed code spans. See section where we close code. --------- Co-authored-by: sevenshamrocks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds target="_blank" text to links in HTML when option is selected in sidebar. This should be the fourth pull request.
Addresses issue #137 & #154