Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to use RabbitMQ docker container #528

Merged
merged 1 commit into from
Aug 31, 2018

Conversation

idubnori
Copy link
Contributor

@idubnori idubnori commented Aug 31, 2018

Description

Notes

  • Increased about 4 minutes of build time by thick docker image (5GB) downloading time
    • Solutions might be any of followings
      • Use a linux image (< 100MB), if we could get a premium subscription
      • Make or find out more thin container image
      • Caching docker image by AppVeyor setting (I'm not sure the details)

@idubnori
Copy link
Contributor Author

@rasmus Elasticsearch tests failed. Could you please trigger again?
Have checked CI test successful on my forked side.

@rasmus
Copy link
Member

rasmus commented Aug 31, 2018

@idubnori I triggered the build again.

The addition to the build time would be a problem if I could expect builds to start right away, but as it is now with the free plan there's no guarantee. I think this is a step in the right direction as it removes the dependency on the external provider. I'll leave the other PR open as it could be interesting to see when Windows Server 2019 is released, which should have native support for Linux containers. This should hopefully allow us to run Linux containers on the free plan.

@rasmus rasmus merged commit 3ef03ca into eventflow:develop Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants