[Improvement] Daily Plan organization team types #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GloireMutaliko21
changed the title
|
@Cedric921 can you review this one? |
Cedric921
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Everything is good in this PR, I think we can merge it now.
But we need to create another Issue/PR to update :
- Nextjs endpoints for daily plans
- client call functions:
getAllDayPlansAPI(),getMyDailyPlansAPI(),getDayPlansByEmployeeAPI() - hook functions:
getAllDayPlans(),getMyDailyPlans(),getEmployeeDayPlans()
For all these functions we also need to add the params organizationTeamId or activeTeamId so that, when we change the active team in Page , the data (dailyPlan) will be filtered by the new active Team.
|
@GloireMutaliko21 please work on items from above comment as priority |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring of daily plan typing. Added organizationTeamId on model
Regarding this PR : ever-co/ever-gauzy#8082 we need to improve also for Ever Teams corresponding types
Type of Change
Checklist