Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixbug: SOFT FLOW, popups logic when user added the today plan in the past #2941

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

CREDO23
Copy link
Contributor

@CREDO23 CREDO23 commented Aug 20, 2024

Description

There was an issue with popups logic in the case where user starts a new day with a plan (could be defined in the past, i.e. yesterday or days before yesterday)

What I did:

  • I make sure to always test the last time a popup was opened (independently)

Additional changes (small):

  • Start the timer if users ignore the popup (i.e. User clicks 'X' or cancel/Add later button)

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@CREDO23 CREDO23 added bug Something isn't working WEB Web app Ever Teams labels Aug 20, 2024
@CREDO23 CREDO23 self-assigned this Aug 20, 2024
@CREDO23 CREDO23 linked an issue Aug 20, 2024 that may be closed by this pull request
@CREDO23 CREDO23 changed the title fixbug: SOFT FLOW, popups logic when user added the today plan yesterday 👌 fixbug: SOFT FLOW, popups logic when user added the today plan yesterday/ days before yesterday 👌 Aug 20, 2024
@CREDO23 CREDO23 changed the title fixbug: SOFT FLOW, popups logic when user added the today plan yesterday/ days before yesterday 👌 fixbug: SOFT FLOW, popups logic when user added the today plan yesterday or days before yesterday 👌 Aug 20, 2024
@Cedric921 Cedric921 changed the title fixbug: SOFT FLOW, popups logic when user added the today plan yesterday or days before yesterday 👌 fixbug: SOFT FLOW, popups logic when user added the today plan yesterday or days before yesterday Aug 20, 2024
@CREDO23 CREDO23 changed the title fixbug: SOFT FLOW, popups logic when user added the today plan yesterday or days before yesterday fixbug: SOFT FLOW, popups logic when user added the today plan in the past Aug 21, 2024
@evereq evereq merged commit c1bd454 into develop Aug 21, 2024
12 checks passed
@evereq evereq deleted the 2939-bug-planned--soft-flow-does-not-work branch August 21, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Ever Teams WEB Web app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 'Planned' | SOFT flow does NOT work
3 participants