Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2942 feature planned button stat working on the popup #2953

Merged
merged 9 commits into from
Sep 1, 2024
Merged

2942 feature planned button stat working on the popup #2953

merged 9 commits into from
Sep 1, 2024

Conversation

CREDO23
Copy link
Contributor

@CREDO23 CREDO23 commented Aug 23, 2024 •
edited
Loading

Description

This PR fixes #2942 (logic of 'Start working' button on planned tasks popup)

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Current screenshots

Loom

@CREDO23 CREDO23 self-assigned this Aug 23, 2024
@CREDO23 CREDO23 marked this pull request as draft August 23, 2024 09:18
@CREDO23 CREDO23 force-pushed the 2942-feature-planned--button-stat-working-on-the-popup branch from f22ca14 to 9d5fb41 Compare August 23, 2024 16:49
@CREDO23
feat: add more elements to the 'Planned tasks' popup
0aaf688 
feat: add warning messages

feat: add logic of 'Start working' button on the planned tasks popup
@CREDO23 CREDO23 force-pushed the 2942-feature-planned--button-stat-working-on-the-popup branch from 9d5fb41 to 173336c Compare August 23, 2024 16:56
@CREDO23 CREDO23 marked this pull request as ready for review August 23, 2024 17:19
Base automatically changed from 2948-task-planned--ui-add-more-elements-to-the-popup-planned-tasks to 2943-task-planned--implement-default-selected-task August 23, 2024 22:07
@CREDO23 CREDO23 force-pushed the 2942-feature-planned--button-stat-working-on-the-popup branch from 173336c to 999f3ce Compare August 26, 2024 08:24
Base automatically changed from 2943-task-planned--implement-default-selected-task to develop August 27, 2024 06:53
@evereq
Copy link
Member

evereq commented Aug 28, 2024

@CREDO23

  1. you removed translation in some places and hardcoded text
  2. In some places used .then(), can't we use await?

@Cedric921 can you also review this PR today please?

@GloireMutaliko21 make sure you check this PR before work on things mentioned in comment for other PR

@CREDO23
Copy link
Contributor Author

CREDO23 commented Aug 28, 2024

@CREDO23

  1. you removed translation in some places and hardcoded text
  2. In some places used .then(), can't we use await?

@Cedric921 can you also review this PR today please?

@GloireMutaliko21 make sure you check this PR before work on things mentioned in comment for other PR

@evereq Let me fix that

@evereq evereq merged commit 76f9c20 into develop Sep 1, 2024
10 of 12 checks passed
@evereq evereq deleted the 2942-feature-planned--button-stat-working-on-the-popup branch September 1, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cedric921 Cedric921 Cedric921 approved these changes

@evereq evereq Awaiting requested review from evereq

@KostyaEver KostyaEver Awaiting requested review from KostyaEver

Assignees

@CREDO23 CREDO23

Labels
Ever Teams WEB Web app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] 'Planned' | Button 'Stat working' on the popup
3 participants
@CREDO23 @evereq @Cedric921