Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix game_name or gn->n typo #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix game_name or gn->n typo #34

wants to merge 1 commit into from

Conversation

lasers
Copy link

@lasers lasers commented Jun 5, 2023

Hi. If I want to sort by game_name, the manual page say I can use game_name or n.

  -s SORT, --sort SORT  sort search output by column name, can string multiple names by using a comma.  Available options are: console or c, title_id or id, region or r,
                        type or t, game_name or n, size or s. Default value: c,t,r,n

Using game_name works fine.

Using n gives this error.

[ERROR] invalid list for --order

Using gn gives this error.

Traceback (most recent call last):
  File "~/src/pynps/.venv/bin/pynps", line 33, in <module>
    sys.exit(load_entry_point('pynps', 'console_scripts', 'pynps')())
  File "~/src/pynps/pynps/cli/cli.py", line 291, in cli_main
    maybe_download = search_db(system, what_to_dl, args.search, reg, args.sort, DBFOLDER)
  File "~/~src/pynps/pynps/functions/functions.py", line 579, in search_db
    order = [variables.ORDER_DIC[x] for x in order.split(",")]
  File "~/src/pynps/pynps/functions/functions.py", line 579, in <listcomp>
    order = [variables.ORDER_DIC[x] for x in order.split(",")]
KeyError: 'gn'

Simple gn->n typo fix. Thank you for this tool. I hope you don't stop working on it. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant