[WIP] Everypolitician::Positions prototype #15608
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This pull request is a prototype of an
Everypolitician::Positions
class for interacting with position data.Why was this needed?
We want to add cabinet data to the term pages and in order to do this we need to interact with the position data from everypolitician-data. This data is currently in the
unstable
directory of each legislature, and therefore isn't available from the everypolitician gem yet.Relevant Issue(s)
Implementation notes
I think I've actually got two changes going on here:
So I think I probably want to end up with one pull request which adds the
Position
andPositions
classes, and then a separate one that adds theUnstablePositionCSV
class which can then return an instance ofPositions
. Then when we decide on where we want the CSVs to live we can just switch outUnstablePositionCSV
for something else.Notes to Merger