Add democratic commons links

[wrightmartin]

What does this do?

Adds information to the EveryPolitician website about the Democratic Commons project it is now part of. It's barebones and I expect when assets exist we will come back and add a logo or graphic treatment.

Why was this needed?

Previously there were no links at all

Relevant Issue(s)

Implementation notes

None, just basic HTML and CSS changes

Screenshots

Homepage

Country page

Notes to Reviewer

Notes to Merger

[tmtmtmtm]

Thanks for this @wrightmartin

There are a few problems here, though:

• travis is failing:
  • Note that this repo has an enforced check that any non-refactoring PR adds a test that not only passes on the branch, but also fails on master. In this case that would probably be a matter of making sure that one of the country pages has a link to mysociety.org/democracy/democratic-commons (I'd be happy to add something like this myself if you're not comfortable doing that)
• you've left a fixup commit in: you should squash that
• there's a typo on "contribute"

More fundamentally, though, I'm not convinced that this change makes sense in isolation. It gives a quite confusing message about the project, particularly as it's placed right next to a "How to contribute" link that mentions nothing at all about Wikidata or the Commons, and indeed gives conflicting information.

I've opened everypolitician/everypolitician-docs#43 to track the larger rewrite: we don't necessarily need to block this on all of that, but I don't think we can put this live without making at least some additional changes.

[tmtmtmtm]

contribute

[wrightmartin]

Thanks for the feedback @tmtmtmtm - typo fixed, fixup gone.

I've not written a test before but I took a run at it - see what you think

[wrightmartin]

More fundamentally, though, I'm not convinced that this change makes sense in isolation. It gives a quite confusing message about the project, particularly as it's placed right next to a "How to contribute" link that mentions nothing at all about Wikidata or the Commons, and indeed gives conflicting information.

Make sense to me - but in this case you're talking to the monkey and not the organ grinder - @rich-cassidy will be the one to talk to regarding that

[wrightmartin]

oh, I see the test is failing, although they passed locally - we are now outside of my area of competence

[tmtmtmtm]

@wrightmartin it's quite well buried in a wall of text, but I don't think it's your new test that's failing here, but instead it's complaining at line 3632(!):

http://localhost:4567/images/screencast.gif:
2018-04-04 11:43:02 ERROR 404: Not Found.

This is because one of the tests is to essentially try to generate the static site and make sure we're able to do so, but you've removed this image, even though it's still linked from views/house.erb.

[wrightmartin]

This is because one of the tests is to essentially try to generate the static site and make sure we're able to do so, but you've removed this image, even though it's still linked from views/house.erb.

Aha, hadn't spotted that, have replaced it with the same as the country template

[tmtmtmtm]

Great! Looks like the only thing travis is complaining about now is the awkward spacing in before { get '/iran/' } (NB: running the default rake task — i.e. bundle exec rake — will run not only the tests, but also the rubocop / reek checks etc, which will show you these)

[rich-cassidy]

@tmtmtmtm @wrightmartin

More fundamentally, though, I'm not convinced that this change makes sense in isolation. It gives a quite confusing message about the project, particularly as it's placed right next to a "How to contribute" link that mentions nothing at all about Wikidata or the Commons, and indeed gives conflicting information.

With regards to this, what accompanying change would be helpful to eliminate / reduce the confusion? It is changing the 'Contribute data' section to mention add info into Wikidata and/or pointing to an appropriate place on Wikidata (perhaps the Wikiproject page)?

All changes made and tests added

[tmtmtmtm]

@rich-cassidy everypolitician/everypolitician-docs#43 is tracking the related changes that we would need to make to the docs

[tmtmtmtm]

All changes made and tests added

Thanks @wrightmartin — I suspect we might need to tweak some of this again before putting it live once the wider issue is resolved, but maybe by then we'll also have accompanying assets too ;)