#18: Add checker for unused and undeclared dependencies #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nifadyev, thank you! That's awesome feature |
soltanoff
approved these changes
Dec 9, 2024
soltanoff
reviewed
Dec 9, 2024
| @@ -84,6 +84,8 @@ lint: | |||
| make check | |||
| @# For some reason, mypy and pylint fails to resolve PYTHONPATH, set manually. | |||
| PYTHONPATH=./app $(MANAGER) run pylint app | |||
| $(MANAGER) run deptry backend | |||
soltanoff
reviewed
Dec 9, 2024
nifadyev
force-pushed
the
infra/#18/add-check-for-unused-and-undeclared-deps
branch
from
a3fcf1c to
08220e5
Compare
nifadyev
deleted the
infra/#18/add-check-for-unused-and-undeclared-deps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR contains configuration examples for deptry and fawltydeps.
The main differences are:
deptryunable to find such undeclared dependencies ascelery,fawltydepsrequires fine-grained configuration to avoid false positives likedjango(Djangoinpyproject.toml).deptryconverts package names tocamel_caseif necessarydjango-environ(imported asenviron)deptryrequires more configuration forDjangoprojects to avoid false positives for packages which are not used in codebase (for example,django-cors-headers)fawltydepsunable to resolve packages from private pypi (core-python-client, .etc)As a result, neither of these tools is good enough. But they can be used in tandem to achieve desired behavior. Unfortunately, with extra configuration.
Detailed output could be found in deptry_worklogs_toggl_output.txt and fawltydeps_worklogs_toggl_output.txt
Resolves #18