Feature/highlight2 #235
Merged
Feature/highlight2 #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The words at the end of the line that do not coincide with the end of a line were attached to those of the next line. Now a space has been added.
…layouts when initialized
…_rules Fix for editorial conventions
Fix missing space in verses display in dipl transcription
add class attribute on G Text Verse Choice component
…rallelPassage elements, optimize critical-apparatus-component code,
… and external sources in analogue and quote data structure
…ables for bibliography in edition_config.json
…nside analogues folder
…ver event for quotes and analogues
…of bibliographic elements parsing
…source components and note components when used to display one of them
…rse l, versesgroup lg and div
…s' and 'analogues'
The image panel shows the first available image on the surfaces list. The icon in the header is temporary from FontAwesome icon set. In the Image Panel an evt-nav-bar-image component is added but not used in this feature: it is prepared for the Image-Image view to make nav-bar indipendent for each Image view. This Image Only feature is tested on the VB_DOTR.xml file with four images, one for each manuscript page, contained in the src\assets\data\images\single\DOTR folder. Files modified are: - app-routing.module.ts to introduce new imageOnly Route - app.module.ts to import NavBarImageComponent and ImageOnlyComponent - osd.component.ts to set input Surface and Page - main-header.component.html to set dynamic iconSet - evt-models.ts to introduce new imageOnly ViewModeId - image-panel.component.ts to implement currentSurface and currentPage - image-panel.component.html to bind currentSurface and currentPage Files added are: - nav-bar-image.component.html - nav-bar-image.component.ts - nav-bar-image.component.scss - image-only.component.html - image-only.component.ts - image-only.component.scss
click on text/image select line
…own indipentent NavBar. The icon in the header NavBar is provisional. The maximum number of opened panels is 4. Minimum is 2. Images to be shown can be selected from the dropdown placed on the upper part of every panel. This feature is tested on VB-DOTR.
A button on the top of the image panel switch on and off the syncronization. Each zone/line can be selected and deselected by clicking on it (line or zone). A new property is added in ui_config to activate the highlight syncronization button
# Conflicts: # src/app/app.component.ts # src/app/components/osd/osd.component.ts # src/app/nav-bar-image/nav-bar-image.component.html # src/app/nav-bar-image/nav-bar-image.component.ts # src/app/panels/image-panel/image-panel.component.html # src/app/panels/image-panel/image-panel.component.ts # src/app/view-modes/image-image/image-image.component.html # src/app/view-modes/image-image/image-image.component.ts # src/app/view-modes/image-only/image-only.component.html
Edit file_config: added single and double properties to imageFolderUrls
…_frame Feature/app source analogues frame
- facsimile with rend=double - facsimile with surfaceGrp-->surface< Show Image-Image component using priority: - facsimile with only surface - facsimile with surfaceGrp-->surface - pb @url Show Text-Image component using priority: - facsimile with only surface - facsimile with surfaceGrp-->surface Edited file_config: added single and double properties to imageFolderUrls: "imagesFolderUrls":{ "single": "assets/data/images/single/", "double": "assets/data/images/double/" },
# Conflicts: # src/app/app.module.ts # src/app/components/verse/verse.component.html # src/app/services/evt-model.service.ts # src/app/services/evt-status.service.ts # src/app/services/xml-parsers/basic-parsers.ts # src/assets/i18n/en.json # src/assets/i18n/it.json # src/styles.scss
Manage generic points in zone mapping ESLint fixed Small bug fixing Cleaning code Fixing url for image retrieving from facs Highlight also for chunk tags (only verse)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: Enable the syncronized HighLighting of the image and the text. A button on the top of the image panel switch on and off the syncronization. Each zone/line can be selected and deselected by clicking on it (line or zone). A new property is added in ui_config to activate the highlight syncronization button + FIX for Release