Merge pull request #189 from ewasm/evmc-failure

Return EVM_FAILURE and not EVM_INTERNAL_ERROR for contract issues
ewasm · Apr 19, 2018 · 7699c93 · 7699c93
2 parents 753c85c + b6634e9
commit 7699c93
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/hera.cpp b/src/hera.cpp
@@ -348,7 +348,9 @@ evm_result evm_execute(
     cerr << e.what() << endl;
 #endif
   } catch (InternalErrorException const& e) {
-    ret.status_code = EVM_INTERNAL_ERROR;
+    // TODO: split exceptions properly, but for now this mostly (>90%) covers
+    // issues in the contracts, as opposed to unrecoverable issues in Hera
+    ret.status_code = EVM_FAILURE;
 #if HERA_DEBUGGING
     cerr << "InternalError: " << e.what() << endl;
 #endif