Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

squid with debian 12 has now a conf.d dir #77

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

dagobert
Copy link
Contributor

squid in Debian Bookworm (12) has now a conf.d directory.

squid in Debian Bookworm (12) has now a conf.d directory.
@alvagante
Copy link
Member

@dagobert if it's only for Debian 12, it' better to add the line in a new file: squid/osfamily/Debian12.yaml

@dagobert
Copy link
Contributor Author

dagobert commented Feb 27, 2024

I am only using Debian, hence I don't know about other distributions and their releases.

The descision is yours to make. I think it belongs in the default file since it is a directory you implemented in tp::conf as a short - as also described in the readme. I mean that it is in general not an unusula directory for many services.
I was thinking ahead imagining what happens other dirstibutions also add this conf.d directory. Than you would need to decide again to add an exception and on some point there are more exception than the default. Hence, I would, since this exact directory is part of your standard implementation, add it to default.
Also, no one needs to use it and will use it on accident.
It is your Project in the end.

@alvagante alvagante merged commit 87730d6 into example42:master Apr 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants