Fix the big bug between the chair and the screen

exanauts · Dec 8, 2023 · 3d457e6 · 3d457e6
1 parent 0ae52e5
commit 3d457e6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/generic.jl b/src/generic.jl
@@ -21,7 +21,7 @@ end
 
 function LinearAlgebra.cholesky(A::CuSparseMatrixCSR{T,Cint}) where T <: BlasFloat
   n = LinearAlgebra.checksquare(A)
-  structure = T <: Real ? "SDP" : "HDP"
+  structure = T <: Real ? "SPD" : "HPD"
   solver = CudssSolver(A, structure, 'F')
   x = CudssMatrix(T, n)
   b = CudssMatrix(T, n)
@@ -46,11 +46,11 @@ end
 for type in (:CuVector, :CuMatrix)
   @eval begin
     function LinearAlgebra.ldiv!(solver::CudssSolver, b::$type{T}) where T <: BlasFloat
-      cudss("factorization", solver, b, b)
+      cudss("solve", solver, b, b)
     end
 
     function LinearAlgebra.ldiv!(x::$type{T}, solver::CudssSolver, b::$type{T}) where T <: BlasFloat
-      cudss("factorization", solver, x, b)
+      cudss("solve", solver, x, b)
     end
   end
 end
diff --git a/test/test_cudss.jl b/test/test_cudss.jl
@@ -230,7 +230,7 @@ function cudss_generic()
         B_gpu = CuMatrix(B_cpu)
 
         solver = ldlt(A_gpu)
-        (structure == 'H') && cudss_set(solver, "pivot_type", 'N')
+        (T <: Complex) && cudss_set(solver, "pivot_type", 'N')
         ldiv!(X_gpu, solver, B_gpu)
         R_gpu = B_gpu - A_gpu * X_gpu
         @test norm(R_gpu) ≤ √eps(R)