-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big refresh, slightly breaking #11
Conversation
LGTM (besides the missing new line in the yml files). As per the discussion with @amontoison I'd move the package to the Exanauts org if you don't mind. I added you to this repository so you can push the branch and the CI runs. |
Cool, thanks! I'll finish the PR tomorrow. I'm also writing a pure Julia version so we'll be able to compare speed 😊 |
@gdalle Can you update the Julia wrappers to use the macro |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
To have passing tests I had to fix the source of randomness generating the sparse matrix (otherwise the results you get depend on the version of Julia). I also had to modify the number of colors accordingly for some coloring algorithms. @michel2323 can you check that it still looks okay? Then I think we're good to merge.
@amontoison it's done but I've never written a line of C so please double-check |
Co-authored-by: Alexis Montoison <[email protected]>
@michel2323 should we merge? |
Hey there @michel2323!
This PR fixes #9 by modernizing and cleaning up the package, in the hope of getting it the appreciation it deserves. I tried to apply the current best practices in terms of package structure, as described in my blog https://modernjuliaworkflows.github.io/. I also added a lot of documentation, and a few breaking changes which I feel make sense (see below). However, the basic functionalities were not altered.
These changes affect ADNLPModels.jl (ping @amontoison) but the fixes are easy to apply so I'll take care of them if you accept.
Source code
AbstractColoring
,AbstractOrdering
and the listsCOLORINGS
andORDERINGS
ColoringMethod
andColoringOrder
with one string attribute (instead of an abstract type)d1_coloring
and friends as shortcuts to these structs (instead of identical but separate structs). They no longer accept a string argument, since it was redundant.ColPackColoring
to use references instead of length-1 vectorsccall
with the macro@ccall
Documentation
Tests
Example
Esthetics
.JuliaFormatter.toml
file for uniform style enforcement, apply formatting with JuliaFormatter.jlCompat
CI
dependabot.yml
to track outdated dependenciesTest.yml
andTagBot.yml
Documentation.yml
to build a docs website and deploy it