Refactoring/#219 applied ptb checks and fixes #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckunki
commented
Nov 20, 2024
There was a problem hiding this comment.
After #217 there was still another copy of mock_cast.py in test/utils.
So I changed all imports to import test/utils and removed tests/mock_cast.py.
ckunki
commented
Nov 20, 2024
There was a problem hiding this comment.
This module was not imported by any other and the contained class had been moved to interface.py in PR #203.
ckunki
commented
Nov 20, 2024
There was a problem hiding this comment.
I replaced all local imports in this package by fully qualified to avoid circular dependencies.
ahsimb
previously approved these changes
Nov 20, 2024
ahsimb
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #219