Update dependencies 2025-01-13 #56
Conversation
Nicoretti
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Nicoretti
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Nicoretti
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Nicoretti
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Nicoretti
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Nicoretti
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Nicoretti
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Nicoretti
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Nicoretti
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Nicoretti
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Nicoretti
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Nicoretti
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
| python-version: ${{ matrix.python-version }} | ||
|
|
||
| - name: Run Tests and Collect Coverage | ||
| run: poetry run nox -s test:integration -- -- --coverage --db-version ${{ matrix.exasol-version }} |
There was a problem hiding this comment.
Will the coverage results be merged with the results for the unit tests?
There was a problem hiding this comment.
In bucketfs-python we needed to use --itde-db-version.
Which one is correct?
There was a problem hiding this comment.
Will the coverage results be merged with the results for the unit tests?
yes the results will be merged.
In bucketfs-python we needed to use --itde-db-version.
Which one is correct?
Depends on what tools and versions of those tools are used
There was a problem hiding this comment.
In bucketfs-python we needed to use
--itde-db-version. Which one is correct?
Depends on what tools and versions of those tools are used
Can you explain this a bit more?
Does error-reporting-python use a database at all?
is --db-version correct here?
Why does bucketfs-python need to use --itde-db-version?
There was a problem hiding this comment.
Why does bucketfs-python need to use --itde-db-version?
Feel free to call me and we have a look at it, but I don't think this is subject of this PR.
That said happy to investigate your issues/question at hand regarding bucketfs-python with yout, but not in the context and PR of another project.
Does error-reporting-python use a database at all?
No, but it does have integration tests
is --db-version correct here?
Should be ok, afik if no DB is requested nothing happens with that parameter.
Keeping it aligned with the template will simplify future udpates though.
| python-version: ${{ matrix.python-version }} | ||
|
|
||
| - name: Run Tests and Collect Coverage | ||
| run: poetry run nox -s test:integration -- -- --coverage --db-version ${{ matrix.exasol-version }} |
There was a problem hiding this comment.
In bucketfs-python we needed to use --itde-db-version.
Which one is correct?
Nicoretti
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Nicoretti
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Nicoretti
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Nicoretti
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
| python-version: ${{ matrix.python-version }} | ||
|
|
||
| - name: Run Tests and Collect Coverage | ||
| run: poetry run nox -s test:integration -- -- --coverage --db-version ${{ matrix.exasol-version }} |
There was a problem hiding this comment.
In bucketfs-python we needed to use
--itde-db-version. Which one is correct?
Depends on what tools and versions of those tools are used
Can you explain this a bit more?
Does error-reporting-python use a database at all?
is --db-version correct here?
Why does bucketfs-python need to use --itde-db-version?
|
|
||
| - id: set-matrix | ||
| run: | | ||
| echo "matrix=$(poetry run nox -s matrix:all)" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
If I am correct, then nox task matrix:all is defined in PTB.
But still uses database version 7.1.9, which is quite outdated.
As 7.1.30 and 8.32.0 are already available.
Do you plan to update this?
How can a single project override the default settings?
I propose to support using an environment variable here and to simply set it in the workflow file.
There was a problem hiding this comment.
There are multiple ways to do that, for details see the changlog where this was introduced: https://exasol.github.io/python-toolbox/main/changes/changes_0.20.0.html#added
No description provided.