Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor exception handling for Script Options parser #972

Closed
tomuben opened this issue Oct 8, 2024 · 0 comments · Fixed by #976
Closed

Refactor exception handling for Script Options parser #972

tomuben opened this issue Oct 8, 2024 · 0 comments · Fixed by #976
Assignees
@tomuben
Labels
refactoring Code improvement without behavior change

Comments

@tomuben
Copy link
Collaborator

tomuben commented Oct 8, 2024

Background

Currently, an exception handler method is passed down to the parser. This is not need. We can change the code so that the clients throws an exception and the Java VM implementation catches it.

Acceptance Criteria

  1. Change the legacy and ctpg parser implementation to throw exception, instead calling the callback method throwException.
@tomuben tomuben assigned tomuben and unassigned tomuben Oct 8, 2024
@tomuben tomuben added the refactoring Code improvement without behavior change label Oct 8, 2024
This was referenced Oct 8, 2024
Merged
Merged
tomuben added a commit to exasol/script-languages that referenced this issue Oct 10, 2024
@tomuben
#972: Refactored exception handling for Script Options parser (#458)
7756307 
related to exasol/script-languages-release#972
tomuben added a commit that referenced this issue Oct 10, 2024
@tomuben
#972: Refactor exception handling for Script Options parser
302aa74 
#973: Support new lines in script options values
@tomuben tomuben mentioned this issue Oct 10, 2024
Merged
10 tasks
tomuben added a commit that referenced this issue Oct 10, 2024
@tomuben
#972: Refactor exception handling for Script Options parser
e285963 
#973: Support new lines in script options values
@tomuben tomuben linked a pull request Oct 10, 2024 that will close this issue
#972 and #973: Refactorings for Script Options parser #976
Merged
10 tasks
tomuben added a commit that referenced this issue Oct 11, 2024
@tomuben
#972 and #973: Refactorings for Script Options parser (#976)
dd30daf 
- #972: Refactor exception handling for Script Options parser
- #973: Support new lines in script options values
@tomuben tomuben closed this as completed Oct 11, 2024
tomuben added a commit that referenced this issue Oct 15, 2024
@tomuben
Merge pull request #979 from exasol/develop
0d90dc1 
Changelist:

- * #944: Removed exaudfclient_bin_py3 (#975)
- * #967: Added ctpg script options parser (#968)
- * #972 and #973: Refactorings for Script Options parser (#976)
- * #977: Fixed Trivy update cache workflow (#978)
tomuben added a commit that referenced this issue Nov 14, 2024
@tomuben
Update master
f2edb41 
Changelist:

- #944: Removed exaudfclient_bin_py3 (#975) 
- #967: Added ctpg script options parser (#968) 
- #972 and #973: Refactorings for Script Options parser (#976) 
- #977: Fixed Trivy update cache workflow (#978) 
- #969: Use new CTPG parser in java vm (#970) 
- #980: Moved flavor template-Exasol-all-java-17 to script-languages repo (#984)
- #971: Removed dead code in Java VM (#985) 
- Refactorings in ScriptOptions parser (#987) 
- #988: Adapted Java integration tests for new ScriptOptions parser (#995) 
- #997: Added documentation for Rollback of Script-Languages-Container (#999)
- #878: Fixed jvmoption and parameters containing a space (#1001) 
- #1002: Use ECR fallback repository for Trivy caching (#1004) 
- #1006: Updated Dependencies on top of 8.4.0 (#1007) 
- #958: Fix conda version conflict (#1010) 
- #1009: Removed NVIDIA GPU Driver Libraries from template-CUDA SLC (#1012)
- Bumped version to 9.0.0 (#1013) 
- #1014: Fixed Push Docker Test Container workflow (#1015)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomuben tomuben

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#972 and #973: Refactorings for Script Options parser exasol/script-languages-release
1 participant
@tomuben