Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#972 and #973: Refactorings for Script Options parser #976

Merged
merged 4 commits into from
Oct 11, 2024
Merged

#972 and #973: Refactorings for Script Options parser #976

merged 4 commits into from
Oct 11, 2024

Conversation

tomuben
Copy link
Collaborator

@tomuben tomuben commented Oct 10, 2024 •
edited
Loading

fixes #973 Support new lines and white spaces at the beginning in script options values
fixes #972 Refactor exception handling for Script Options parser

All Submissions:

  • Check if your pull request goes to the correct bash branch (develop or master)?
  • Is the title of the Pull Request correct?
  • Is the title of the corresponding issue correct?
  • Have you updated the changelog?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Are you mentioning the issue which this PullRequest fixes ("Fixes...")

When integrating to Develop branch:

  1. Remember to merge with "Squash and Merge"

When integrating to Main branch:

  1. Remember to merge with "Merge"
  2. Have you thought about version number? If there is a breaking change in the toolchain, need to update major version.
  3. If you plan a release, have you checked the Exasol packages for updates?
    1. Websocket API (https://github.com/EXASOL/websocket-api)
    2. Exasol-BucketFS

@tomuben tomuben force-pushed the refactoring/973_972_refactoring_script_options_parser branch from 4c27fed to f38acbb Compare October 10, 2024 14:22
tkilias
tkilias previously approved these changes Oct 10, 2024
View reviewed changes
This was linked to issues Oct 10, 2024
Refactor exception handling for Script Options parser #972
Closed
Support new lines in script options values #973
Closed
@tomuben tomuben merged commit dd30daf into develop Oct 11, 2024
7 of 8 checks passed
@tomuben tomuben deleted the refactoring/973_972_refactoring_script_options_parser branch October 11, 2024 08:59
tomuben added a commit that referenced this pull request Oct 15, 2024
@tomuben
Merge pull request #979 from exasol/develop
0d90dc1 
Changelist:

- * #944: Removed exaudfclient_bin_py3 (#975)
- * #967: Added ctpg script options parser (#968)
- * #972 and #973: Refactorings for Script Options parser (#976)
- * #977: Fixed Trivy update cache workflow (#978)
tomuben added a commit that referenced this pull request Nov 14, 2024
@tomuben
Update master
f2edb41 
Changelist:

- #944: Removed exaudfclient_bin_py3 (#975) 
- #967: Added ctpg script options parser (#968) 
- #972 and #973: Refactorings for Script Options parser (#976) 
- #977: Fixed Trivy update cache workflow (#978) 
- #969: Use new CTPG parser in java vm (#970) 
- #980: Moved flavor template-Exasol-all-java-17 to script-languages repo (#984)
- #971: Removed dead code in Java VM (#985) 
- Refactorings in ScriptOptions parser (#987) 
- #988: Adapted Java integration tests for new ScriptOptions parser (#995) 
- #997: Added documentation for Rollback of Script-Languages-Container (#999)
- #878: Fixed jvmoption and parameters containing a space (#1001) 
- #1002: Use ECR fallback repository for Trivy caching (#1004) 
- #1006: Updated Dependencies on top of 8.4.0 (#1007) 
- #958: Fix conda version conflict (#1010) 
- #1009: Removed NVIDIA GPU Driver Libraries from template-CUDA SLC (#1012)
- Bumped version to 9.0.0 (#1013) 
- #1014: Fixed Push Docker Test Container workflow (#1015)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkilias tkilias tkilias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support new lines in script options values Refactor exception handling for Script Options parser
2 participants
@tomuben @tkilias