Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update master #946

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Update master #946

merged 2 commits into from
Aug 19, 2024

Conversation

tomuben
Copy link
Collaborator

@tomuben tomuben commented Aug 19, 2024 •
edited
Loading

All Submissions:

  • Check if your pull request goes to the correct bash branch (develop or master)?
  • Is the title of the Pull Request correct?
  • Is the title of the corresponding issue correct?
  • Have you updated the changelog?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Are you mentioning the issue which this PullRequest fixes ("Fixes...")

When integrating to Develop branch:

  1. Remember to merge with "Squash and Merge"

When integrating to Main branch:

  1. Remember to merge with "Merge"

tkilias and others added 2 commits August 6, 2024 13:50
@tkilias @tomuben
#729: Add rules_jvm_external to Bazel and add a test maven dependency (…
7dc4b7e 
…#730)

fixes #729
---------

Co-authored-by: Thomas Ubensee <[email protected]>
@tomuben @tkilias
#685: updated bazel (#942)
a3c208f 
fixes #685 

- Use new MODULE.bazel instead of WORKSPACE
  - Convert the base part in Script-Languages to a submodule, which then can be used from the exaudfclient in Script-Languages and Script-Languages-Release. This simplifies the packaging of the UDF client in the Script-Languages-Container as we don't need to mess around with symlinks for the binaries in the former Script-Languages Bazel package.
 - Convert the rules for external packages (zmq, protobuf, Python, Java,...) to be complient to the new MODULE implementation
 - Use MODULE dependencies were applicable
    - Maven
- Refactor the Java BUILD file
  - The new version of Bazel does not support directories in the out attribute of a rule. We need to specify each single output file
  - Removed unnecessary rules
  - Pass only needed files to the filter rules
 - Clean up Conda flavors
   - Pin only given packages, but not all (already installed) packages
   - Remove transitive dependencies in conda package files
   - Test if CUDA flavors still work correctly with Pytorch and Tensorflow + Nvidia GPU
   -  Remove dependency to OpenJDK: Bazel defines this dependency. We don't need it explicitely.

---------

Co-authored-by: Torsten Kilias <[email protected]>
@tomuben tomuben merged commit 8850344 into master Aug 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomuben @tkilias