#992: added design doc for script options #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomuben
force-pushed
the
doc/992_add_design_doc_for_script_options
branch
from
3522853 to
0a2684d
Compare
tkilias
reviewed
Nov 17, 2024
tkilias
reviewed
Nov 18, 2024
tkilias
reviewed
Nov 18, 2024
tomuben
force-pushed
the
doc/992_add_design_doc_for_script_options
branch
from
b6dca79 to
207e27f
Compare
tkilias
reviewed
Dec 4, 2024
tkilias
reviewed
Dec 4, 2024
tkilias
reviewed
Dec 4, 2024
tkilias
reviewed
Dec 4, 2024
tkilias
reviewed
Dec 4, 2024
tkilias
reviewed
Dec 4, 2024
tkilias
reviewed
Dec 4, 2024
tkilias
reviewed
Dec 4, 2024
tkilias
reviewed
Dec 4, 2024
tkilias
reviewed
Dec 4, 2024
tkilias
reviewed
Dec 4, 2024
tkilias
reviewed
Dec 4, 2024
tkilias
reviewed
Jan 3, 2025
tkilias
reviewed
Jan 3, 2025
tkilias
reviewed
Jan 3, 2025
tkilias
reviewed
Jan 3, 2025
tkilias
reviewed
Jan 3, 2025
tkilias
reviewed
Jan 3, 2025
tkilias
reviewed
Jan 3, 2025
tkilias
reviewed
Jan 3, 2025
| ### Java %jar Option Collection | ||
| `dsn~java-jar-option-collection~1` | ||
|
|
||
| Implement an algorithm in class `ConverterV2` to split the given Jar option value by colon (':') and then collect the found Jar options in a list. |
There was a problem hiding this comment.
Add our links about what are legal classpaths
There was a problem hiding this comment.
The link is already mentioned in the covered requirement: req~java-jar-option-handling-multiple-options~1.
There was a problem hiding this comment.
someone might not read the requirement and only the design
…doc_for_script_options
Co-authored-by: Torsten Kilias <[email protected]>
… ->`Java %scriptclass Option Handling`
…t_options' into doc/992_add_design_doc_for_script_options
tkilias
reviewed
Jan 20, 2025
| @@ -161,7 +178,7 @@ The following diagram shows how the scripts are collected in the recursive algor | |||
|
|
|||
| ### Parser Implementation V1 | |||
|
|
|||
| The legacy parser (V1) parser searches for one specific script option. The parser starts from beginning of the script code. If found, the parser immediately removes the script option from the script code and returns the option value. It validates the | |||
| The legacy parser (V1) parser searches for one specific script option. The parser starts from the beginning of the script code. If found, the parser immediately removes the script option from the script code and returns the option value. It validates the | |||
There was a problem hiding this comment.
It validates the
Incomplete sentence
…doc_for_script_options
tkilias
reviewed
Jan 20, 2025
Fix from review Co-authored-by: Torsten Kilias <[email protected]>
tkilias
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to exasol/script-languages-release#992