Added task_type parameter for correct model loading #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckunki
changed the title
tkilias
requested changes
Jul 15, 2024
exasol_transformers_extension/utils/current_model_specification.py
Outdated
Show resolved
Hide resolved
exasol_transformers_extension/utils/current_model_specification.py
Outdated
Show resolved
Hide resolved
tkilias
reviewed
Jul 15, 2024
tests/fixtures/model_fixture.py
Outdated
|
|
||
| @pytest.fixture(scope="session") | ||
| def prepare_base_model_for_local_bucketfs(tmpdir_factory) -> PurePosixPath: | ||
| def prepare_question_answering_model_for_local_bucketfs(tmpdir_factory) -> PurePosixPath: | ||
| model_specification = model_params.base_model_specs |
There was a problem hiding this comment.
I think, you should select one model per task for testing, because the base_model "bert_uncased" can't be used for all tasks. I think, it can be used for mask filling, sequence classification, zero shot classification and maybe text generation. I think, it can't used for translation, question answering.
tkilias
reviewed
Jul 19, 2024
tests/integration_tests/with_db/udfs/test_sequence_classification_text_pair_script.py
Outdated
Show resolved
Hide resolved
tests/integration_tests/with_db/udfs/test_token_classification_script.py
Outdated
Show resolved
Hide resolved
tests/integration_tests/with_db/udfs/test_zero_shot_text_classification_script.py
Outdated
Show resolved
Hide resolved
tkilias
reviewed
Aug 5, 2024
tkilias
reviewed
Aug 5, 2024
tkilias
reviewed
Aug 5, 2024
tkilias
reviewed
Aug 5, 2024
tkilias
reviewed
Aug 5, 2024
tkilias
reviewed
Aug 5, 2024
tests/integration_tests/without_db/udfs/test_sequence_classification_single_text_udf.py
Outdated
Show resolved
Hide resolved
tkilias
reviewed
Aug 5, 2024
| bucketfs_connections = [Connection(address=f"file:///test{i}") for i in range(count)] | ||
| bfs_conn_name = [f"bfs_conn_name_{i}" for i in bucketfs_connections] | ||
|
|
||
| mock_cmss = [create_autospec(CurrentModelSpecification, | ||
| mock_cmss = [create_autospec(BucketFSModelSpecification, | ||
| model_name=base_model_names[i], |
There was a problem hiding this comment.
wow, cool, that I didn't knew
tkilias
previously approved these changes
Aug 5, 2024
…aiting for the SLC build while the SaaS DB is already running [CodeBuild]
…e without need and make db_conn a session fixture [CodeBuild]
…ach test. It seems to be a bug that a session scope fixture is called for every test. This might happen because backend is parameterized. [CodeBuild]
…CodeBuild [CodeBuild]
… them [CodeBuild]
|
|
||
| _BACKEND_OPTION = '--backend' | ||
|
|
||
| def pytest_addoption(parser): |
There was a problem hiding this comment.
we should rename this on to pytest_add_option at some point, adoption is something else.
There was a problem hiding this comment.
This function name is defined by pytest and can't be changed
tkilias
approved these changes
Aug 7, 2024
MarleneKress79789
deleted the
bug/add_task_type_parameter_for_correct_model_loading
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
[CodeBuild]to the commit messagethis pr is a mismash of tickets to get to a working release as fast as possible. it aims to fix the main problems presented in #213. in order to archive this it partly does tasks in these tickets:
#221
#220
#219
and fixes #218