Initial implementation #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadorovsky
force-pushed
the
initial
branch
6 times, most recently
from
4dee329 to
019ff72
Compare
cross-llvm is a tool for easy cross (but also native) builds using LLVM (clang, Rust). It consists of: - Container images which provide the toolchains for each target. - A CLI tool, which is a wrapper about a container engine (Docker, podman) and allows easy execution of the toolchain. Provided container images can be used with https://github.com/cross-rs/cross
Command which executes `clang` in a containerized cross environment.
Cross wrappers for musl containers are already provided by crossdev[0]. To achieve the save effect on Debian containers, create similar wrappers.
tamird
reviewed
Oct 28, 2024
| uuid = { version = "1.10", features = ["v4"] } | ||
| which = "6.0" | ||
|
|
||
| cross-llvm = { path = "cross-llvm" } |
| uuid = { workspace = true } | ||
| which = { workspace = true } | ||
|
|
||
| cross-llvm = { workspace = true } |
| #[error("containerized builds are not supported for target {0}")] | ||
| UnsupportedTarget(String), | ||
| #[error("failed to build a container image")] | ||
| ContainerImageBuild, |
There was a problem hiding this comment.
shouldn't this include a source error?
ditto below
| container_engine: Option<ContainerEngine>, | ||
|
|
||
| /// Do not use existing cached images for the container build. Build from | ||
| /// the start with a new set of cached layers. |
| #[arg(short, long = "tag", name = "tag")] | ||
| tags: Vec<OsString>, | ||
|
|
||
| /// Target triple (optional) |
There was a problem hiding this comment.
why do you need to say optional? doesn't clap do the right thing based on the type?
|
|
||
| pub fn clang(args: RunArgs) -> anyhow::Result<()> { | ||
| let triple: Triple = match args.target { | ||
| Some(ref target) => target.clone().into(), |
There was a problem hiding this comment.
why do you need to clone it? you have it by value. looks like it's because run_container wants the same argument; split the struct and use #[arg(flatten)]
| let mut container = Command::new(container_engine.to_string()); | ||
| container | ||
| .args([ | ||
| OsStr::new("run"), |
There was a problem hiding this comment.
same thing here, overusing OsStr::new imo. you can mostly use &str literals
| ]) | ||
| .args(cmd_args) | ||
| .args(cmd) | ||
| .stdin(Stdio::inherit()) |
There was a problem hiding this comment.
why inherit stdin? again i think we should capture stdio here for a semblance of discipline
|
|
||
| #[derive(Debug, Error)] | ||
| pub enum CrossLlvmError { | ||
| #[error("no supported container engine (docker, podman) was found")] |
There was a problem hiding this comment.
odd to enumerate the options at a distance
|
|
||
| #[derive(Parser)] | ||
| pub struct RunArgs { | ||
| /// Container engine (if not provided, is going to be autodetected) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cross-llvm is a tool for easy cross (but also native) builds using LLVM (clang, Rust).
It consists of:
Provided container images can be used:
cross-llvmCLI.