Add symbols and tuples concept and exercise #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanplusplus
requested changes
Aug 10, 2024
concepts/symbol/.meta/config.json
Outdated
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "blurb": "Symbol represent a unique identifier through the program, which is created at compile time", | |||
There was a problem hiding this comment.
Suggested change
| "blurb": "Symbol represent a unique identifier through the program, which is created at compile time", | |
| "blurb": "Symbols represent unique identifiers throughout the program, which is created at compile time", |
concepts/symbol/about.md
Outdated
| :"foo boo" # => :"foo boo" | ||
| ``` | ||
|
|
||
| Symbols are used in many places in the language, including as keys in namedtuples, to represent method names and variable names. |
There was a problem hiding this comment.
Suggested change
| Symbols are used in many places in the language, including as keys in namedtuples, to represent method names and variable names. | |
| Symbols are used in many places in the language, including as keys in namedtuples and to represent method and variable names. |
I think this is what you intended, but I may have misunderstood.
concepts/symbol/about.md
Outdated
|
|
||
| ## Symbols in Crystal | ||
|
|
||
| Symbols in Crystal is quite different from Ruby. |
There was a problem hiding this comment.
Suggested change
| Symbols in Crystal is quite different from Ruby. | |
| Symbols in Crystal are quite different from Ruby. |
concepts/symbol/about.md
Outdated
| ## Symbols in Crystal | ||
|
|
||
| Symbols in Crystal is quite different from Ruby. | ||
| In Crystal is a symbol a form of constants and is thereby is assigned at compile time. |
There was a problem hiding this comment.
Suggested change
| In Crystal is a symbol a form of constants and is thereby is assigned at compile time. | |
| In Crystal a symbol is a type of constant and is thereby is assigned at compile time. |
concepts/symbol/about.md
Outdated
| In Crystal is a symbol a form of constants and is thereby is assigned at compile time. | ||
| This means that symbols can't be created dynamically, which is possible in Ruby. | ||
|
|
||
| Symbols in Crystal is represented as an `Int32` which makes very efficient. |
There was a problem hiding this comment.
Suggested change
| Symbols in Crystal is represented as an `Int32` which makes very efficient. | |
| Symbols in Crystal are represented as `Int32`s which makes them very efficient. |
config.json
Outdated
Comment on lines
1596
to
1597
| "slug": "tuples", | ||
| "name": "Tuples" |
There was a problem hiding this comment.
Suggested change
| "slug": "tuples", | |
| "name": "Tuples" | |
| "slug": "tuple", | |
| "name": "Tuple" |
Should this be singular or plural? Symbol is singular below and Array is singular above, but some of the concepts are plural.
|
|
||
| ## General | ||
|
|
||
| - [Tuples][tuple] are data structures which are inmutable, have a fixed size, and can hold any data-type. |
There was a problem hiding this comment.
Suggested change
| - [Tuples][tuple] are data structures which are inmutable, have a fixed size, and can hold any data-type. | |
| - [Tuples][tuple] are data structures which are immutable, have a fixed size, and can hold any data-type. |
| ## General | ||
|
|
||
| - [Tuples][tuple] are data structures which are inmutable, have a fixed size, and can hold any data-type. | ||
| - Symbols may be used to denote finite states, as this exercise uses `:cup`, `:fluid_ounce`, `:teaspoon`, `:tablespoon`, `:milliliter` to denote the units used. |
There was a problem hiding this comment.
Suggested change
| - Symbols may be used to denote finite states, as this exercise uses `:cup`, `:fluid_ounce`, `:teaspoon`, `:tablespoon`, `:milliliter` to denote the units used. | |
| - Symbols may be used to denote finite states: this exercise uses `:cup`, `:fluid_ounce`, `:teaspoon`, `:tablespoon`, `:milliliter` to denote the units used. |
| # Instructions | ||
|
|
||
| While preparing to bake cookies for your friends, you have found that you have to convert some of the measurements used in the recipe. | ||
| Being only familiar with the metric system, you need to come up with a way to convert common US baking measurements to milliliters (mL) for your own ease. |
There was a problem hiding this comment.
Suggested change
| Being only familiar with the metric system, you need to come up with a way to convert common US baking measurements to milliliters (mL) for your own ease. | |
| Only being familiar with the metric system, you need to come up with a way to convert common US baking measurements to milliliters (mL) for your own ease. |
Comment on lines
1
to
23
| ## Goal | ||
|
|
||
| The goal of this exercise is to teach the student about modules in Crystal. | ||
|
|
||
| ## Learning objectives | ||
|
|
||
| - Know how to create a module | ||
| - How to include a module in a class | ||
|
|
||
| ## Out of scope | ||
|
|
||
| - How to use mixins between classes | ||
|
|
||
| ## Concepts | ||
|
|
||
| `Modules`: | ||
|
|
||
| - Create a module | ||
| - Include a module in a class | ||
|
|
||
| ## Prerequisites | ||
|
|
||
| - return |
There was a problem hiding this comment.
This looks like a copy paste error
ryanplusplus
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.