Fixed newsletter analysis to allow guard clause

Signed-off-by: Willy Wombat <[email protected]>

lib/elixir_analyzer/test_suite/newsletter.ex

@@ -19,6 +19,14 @@ defmodule ElixirAnalyzer.TestSuite.Newsletter do
         end
       end
     end
+
+    form do
+      def close_log(_ignore) when _ignore do
+        _block_ends_with do
+          :ok
+        end
+      end
+    end
   end
 
   feature "use IO.puts in log_sent_email rather than IO.write as last call" do
@@ -33,6 +41,14 @@ defmodule ElixirAnalyzer.TestSuite.Newsletter do
         end
       end
     end
+
+    form do
+      def log_sent_email(_ignore, _ignore) when _ignore do
+        _block_ends_with do
+          :ok
+        end
+      end
+    end
   end
 
   assert_no_call "use IO.puts in log_sent_email rather than IO.write" do
@@ -55,6 +71,14 @@ defmodule ElixirAnalyzer.TestSuite.Newsletter do
         end
       end
     end
+
+    form do
+      def log_sent_email(_ignore, _ignore) when _ignore do
+        _block_ends_with do
+          :ok
+        end
+      end
+    end
   end
 
   feature "send_newsletter ends with close_log" do
@@ -69,6 +93,14 @@ defmodule ElixirAnalyzer.TestSuite.Newsletter do
         end
       end
     end
+
+    form do
+      def send_newsletter(_ignore, _ignore, _ignore) when _ignore do
+        _block_ends_with do
+          :ok
+        end
+      end
+    end
   end
 
   feature "open_log used the option :write" do
@@ -107,6 +139,14 @@ defmodule ElixirAnalyzer.TestSuite.Newsletter do
         end
       end
     end
+
+    form do
+      def open_log(_ignore) when _ignore do
+        _block_includes do
+          File.open!(_ignore, [:write])
+        end
+      end
+    end
   end
 
   assert_call "send_newsletter/3 calls open_log/1" do

test/elixir_analyzer/test_suite/newsletter_test.exs

@@ -99,6 +99,40 @@ defmodule ElixirAnalyzer.ExerciseTest.NewsletterTest do
           if f.(email) === :ok, do: log_sent_email(log_pid, email)
           do_send(rest, log_pid, f)
         end
+      end,
+      defmodule Newsletter do
+        def read_emails(path) do
+          path
+          |> File.read!()
+          |> String.split()
+        end
+
+        def open_log(path) when is_binary(path) do
+          File.open!(path, [:write])
+        end
+
+        def log_sent_email(pid, email) when is_pid(pid) and is_binary(email) do
+          IO.puts(pid, email)
+        end
+
+        def close_log(pid) when is_pid(pid) do
+          File.close(pid)
+        end
+
+        def send_newsletter(emails_path, log_path, send_fun)
+            when is_binary(emails_path) and is_binary(log_path) and is_function(send_fun, 1) do
+          log_pid = open_log(log_path)
+          emails = read_emails(emails_path)
+
+          Enum.each(emails, fn email ->
+            case send_fun.(email) do
+              :ok -> log_sent_email(log_pid, email)
+              _ -> nil
+            end
+          end)
+
+          close_log(log_pid)
+        end
       end
     ]
   end

test_data/two_fer/imperfect_solution/lib/two_fer.ex

@@ -1,5 +1,4 @@
 defmodule TwoFer do
-	@someUnusedModuleAttribute 1
 
 	defmodule My_empty_module do
 	end