Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling blocks in dna-encoding recursion check #397

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Fix handling blocks in dna-encoding recursion check #397

merged 2 commits into from
Sep 30, 2023

Conversation

angelikatyborska
Copy link
Member

Resolves #396

Silly typo and lack of tests caused this bug 🙃

@angelikatyborska angelikatyborska mentioned this pull request Sep 29, 2023
Closed
jiegillet
jiegillet approved these changes Sep 30, 2023
View reviewed changes
Copy link
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silly typos and lack of tests definitely cause a SIZEABLE portion of bugs in the world :D

@jiegillet jiegillet merged commit 7bb938a into main Sep 30, 2023
6 checks passed
@jiegillet jiegillet deleted the dna-encoding-recursion-check-misled-by-blocks branch September 30, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiegillet jiegillet jiegillet approved these changes

Assignees

@jiegillet jiegillet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DNA encoding automated feedback false positive when using variables
2 participants
@angelikatyborska @jiegillet