Closes #398 - Fixed newsletter analysis to allow guard clause

[octowombat]

Following discussions with @jiegillet and an upstream code fix.

[jiegillet]

Did you change this by mistake?
This is the source of the failing tests.

[octowombat]

I did change it as it caused an unused compiler warning and my setup locally stops in that case!!

I will revert the change and retest. Thanks.

Yes that fixes the tests! I guess I don't know the codebase well enough (yet!)

[jiegillet]

Yup, the compiler warning is on purpose, so we can test if we actually detect it :)

[jiegillet]

Let's also include all of the variations we had before (with and without File, with and without !). I know they are not all super likely, but we might as well.

[octowombat]

I didn't remove any of the existing variants though.

[jiegillet]

I meant let's duplicate all four existing variants and add the when _ignore, not just for File.open!.

Right now if someone uses

        import File
        def open_log(path) when is_binary(path) do
          open!(path, [:write])
        end

It will trigger a comment.

[octowombat]

Gotcha!

[jiegillet]

Sorry one last thing: for completeness, we should add tests for all 8 cases, something like

  test_exercise_analysis "open_log accepts 8 several variants",
    comments_exclude: [ElixirAnalyzer.Constants.newsletter_open_log_uses_option_write()] do
   [ defmodule Newsletter do
        import File
        def open_log(path) when is_binary(path) do
          open!(path, [:write])
        end
    end
  end,
   ....
]

[jiegillet]

That's great, thank you so much for your contribution!

[octowombat]

My pleasure