Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any default parameter in two-fer #432

Merged
merged 3 commits into from
Jul 21, 2024
Merged

Conversation

skeltoac
Copy link
Contributor

Fixes #431

@jiegillet
Copy link
Contributor

jiegillet commented Jul 21, 2024

Hi @skeltoac, thank you for the PR.
While I believe that using "you" as the default parameter is the best way of solving the exercise, it's true that the comment is not accurate, so I'm OK with your proposed change.

That being said, could you:

  1. Fix the failing test intest/elixir_analyzer/test_suite/two_fer_test.exs (basically remove the line 94 test)
  2. Add a new test test_exercise_analysis "accepts any value as the default parameter" (with the line 94 test, the intended solution and maybe an extra one with an atom or something)

Copy link
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks a lot :)

@jiegillet jiegillet merged commit 5228eed into exercism:main Jul 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

two-fer doesn't recognize default argument unless it is "you"
2 participants