Implement the bottle-song exercise

[antoine-duchenet]

Hi !

This is my first full exercise contribution to this repository, please let me know if anything can be improved.

Problem specifications

Please note:

• I did not follow the ambiguous wording of the canonical specifications (see design.md), would it benefit other tracks to update the specs ?
• For now, I let the practices and prerequisites fields empty in the root config.json, waiting for maintainers advices 😃

Resolves #1355 .

[github-actions]

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

• General steps

  • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)

• Any exercise changed

  • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
  • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
  • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?

• Practice exercise changed

  • 🌲 Do prerequisites, practices, and difficulty in config.json need to be updated?
  • 🧑‍🏫 Are the changes in accordance with the community-wide problem specifiations?

• Practice exercise tests changed

  • ⚪️ Are all tests except the first one skipped?
  • 📜 Does <exercise>/.meta/tests.toml need updating?

---

Automated comment created by PR Commenter 🤖.

[jiegillet]

Thank you, nice work!
I've left some suggestions that we can discuss :)

[jiegillet]

Thank you for the quick fixes :)

[jiegillet]

Perfect 🚀
Thank you again, I'm merging it!

[cr0t]

I know that it's a bit late because changes are already merged, but this exercise is extremely similar to the “Beer Song” one.

@jiegillet @antoine-duchenet

[jiegillet]

Yes, that exercise was deprecated and replaced with this one.

[antoine-duchenet]

@jiegillet

My company just launched a HacktoberFest event, is it possible to get this PR (an some recent ones) tagged hacktoberfest-accepted ? 😄

My recent PRs :

• Implement the bottle-song exercise #1369 (this one)
• Fix mistakes in bottle-song typespecs #1375
• Sync docs & metadata #1361
• Sync Phone Number tests with canonical specs #1362
• Sync Parallel Letter Frequency tests with canonical specs #1365

Thanks ! Whatever your answer ! 🚀

[jiegillet]

I'd be happy to do it but the rules say

Your PR/MRs must be created between October 1 and October 31 (in any time zone, UTC-12 thru UTC+14).

So this one won't be eligible, and I believe the other ones won't either. Do you see any of those in your hacktoberfest profile?

I also don't see the hacktoberfest labels, I'm not sure if we are participating this year, I'll check.

[antoine-duchenet]

Your PR/MRs must be created between October 1 and October 31 (in any time zone, UTC-12 thru UTC+14).

Nevermind ! I thought there was some tolerance on the dates !

[angelikatyborska]

I'm not sure if we are participating this year, I'll check.

I think as a whole org (Exercism) we've been avoiding Hacktoberfest for a few years now. It brings too much spam... I don't see any chatter on the Forum nor Discord about it. Past years people at least talked about how they don't want to attend. Seems like nobody cares anymore?

I definitely completely forgot about it and I don't have the time nor energy to include this repository in Hacktoberfest.

[antoine-duchenet]

I'm not sure if we are participating this year, I'll check.

I think as a whole org (Exercism) we've been avoiding Hacktoberfest for a few years now. It brings too much spam... I don't see any chatter on the Forum nor Discord about it. Past years people at least talked about how they don't want to attend. Seems like nobody cares anymore?

I definitely completely forgot about it and I don't have the time nor energy to include this repository in Hacktoberfest.

I have no experience with the efficiency of their "improving" anti-spam methods.

I fully understand your position, it won't prevent me to contribute 😄 . I could have motivated some colleagues to contribute to Exercism thanks to the HF, but it should not be at the cost of your time managing the spam 😓 .