-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pop Count practice exercise #1385
Conversation
Thank you for contributing to Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:
Automated comment created by PR Commenter 🤖. |
Hi! Thanks for this. Two details jump out to me:
|
- Use snake case for function names - Fix exercise order
config.json
Outdated
"bit-manipulation" | ||
], | ||
"prerequisites": [ | ||
"bit-manipulation" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder what other concepts are necessary here. Definitely not just bit-manipulation because on the Elixir track, you can learn bit-manipulation together with anonymous functions literally as a second exercise, right after basics.
Your solution uses multiple clause functions, guards, and tail call recursion. I assume it could also be solved with normal recursion? If it could be solved with normal recursion only, that would be better as a prerequisite than tail call recursion as it's easier.
Do you know which language already published this exercise and has some community solutions that I could look at?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some published on the Elm track.
Some use, tail recursion, recursion, some don't use recursion at all (Elm compile to JS, so you know you have at most 32 bits).
Co-authored-by: Angelika Tyborska <[email protected]>
Co-authored-by: Angelika Tyborska <[email protected]>
{ | ||
"authors": [ | ||
"kahgoh" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since she suggested a new test, I would suggest to add @angelikatyborska to the list of contributors (currently empty therefore missing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine, I have enough attributions on the Elixir track 😁 time to merge!
Thanks again 🙏 |
Adds Pop Count exercise