Add `swift-scheduling` exercise #2536

ErikSchierboom · 2025-03-01T13:43:09Z

This is a proposal to add new date-based exercise. The primary goal is to have more date-based exercises. This exercise requires students to convert strings to dates, and will need to add date arithmetic. I'm open to any improvements, so please consider this a starting point.

As a PoC, I've implemented it in C#: exercism/csharp#2397

tasxatzial

Only reviewed docs

exercises/swift-scheduling/introduction.md

exercises/swift-scheduling/instructions.md

Co-authored-by: Anastasios Chatzialexiou <[email protected]>

IsaacG · 2025-03-01T17:36:15Z

exercises/swift-scheduling/canonical-data.json

+        "meetingStart": "2023-04-19T00:00:00",
+        "description": "Q4"
+      },
+      "expected": "2023-12-29T08:00:00"


How about a test case that wraps around to the next year?

I like that idea. I think it makes the most sense to have that as part of the ASAP tests. I'll add it

On second hand, the quarters suggestion is good! I've updated the description, I'll add the test cases later. Could you check if the description makes sense?

I've added test cases too

ErikSchierboom · 2025-03-01T19:32:18Z

I don't know if anyone has time for it, but it would be great if someone could build an implementation to verify the test cases are correct.

BethanyG · 2025-03-01T19:47:56Z

I don't know if anyone has time for it, but it would be great if someone could build an implementation to verify the test cases are correct.

It'll take me a bit - but I can take a stab at doing one for Python.

IsaacG · 2025-03-01T20:23:49Z

exercises/swift-scheduling/instructions.md

+| `"NOW"`     | -                             | Two hours after the meeting started |
+| `"ASAP"`    | Before 12:00                  | Today at 17:00                      |
+| `"ASAP"`    | After 12:00                   | Tomorrow at 12:00                   |
+| `"EOW"`     | Monday, Tuesday, or Wednesday | Friday at 5:00                      |


5am or 5pm?

The tests say 17:00

exercises/swift-scheduling/canonical-data.json

IsaacG · 2025-03-01T20:50:24Z

exercises/swift-scheduling/canonical-data.json

+        "meetingStart": "2001-04-09T09:00:00",
+        "description": "Q4"
+      },
+      "expected": "2001-12-28T08:00:00"


My implementation says 2001-12-31 is the last workday of this quarter.

Correct, fixed

IsaacG · 2025-03-01T20:52:01Z

I don't know if anyone has time for it, but it would be great if someone could build an implementation to verify the test cases are correct.

https://gist.github.com/IsaacG/08211c0b4769419e297f3b898a07d6dc

ErikSchierboom · 2025-03-02T07:55:45Z

I've updated!

angelikatyborska · 2025-03-02T13:32:12Z

exercises/swift-scheduling/instructions.md

+| `"ASAP"`    | Before 12:00                  | Today at 17:00                      |
+| `"ASAP"`    | After 12:00                   | Tomorrow at 12:00                   |


I think people might complain that it's unclear how to categorize exactly 12:00

Fair point! I'll update to a less ambiguous time.

I meant that between the two categories "Before 12:00" and "After 12:00", the time "exactly at 12:00" isn't contained in either of them 😁

Ah! I also think that 12:00 might be ambiguous between AM and PM. I'll tweak it a bit.

I've updated

angelikatyborska · 2025-03-02T14:10:21Z

I implemented the exercise in Elixir: https://github.com/exercism/elixir/pull/1551/files#diff-a0012d9d95c9713c1480d9f5ae9408ade5ab4bd412a65f3d7b69ed5d880e298d

All the tests made sense and I had a great time solving the exercise. I think students will be very happy to practice date times in a more advanced way ❤️

IsaacG · 2025-03-02T16:41:00Z

» python scheduling.py canonical-data.json
PASS: Test 0
PASS: Test 1
PASS: Test 2
PASS: Test 3
PASS: Test 4
PASS: Test 5
PASS: Test 6
PASS: Test 7
PASS: Test 8
PASS: Test 9
PASS: Test 10
PASS: Test 11
PASS: Test 12
PASS: Test 13

I think the data looks reasonable ;)

ErikSchierboom · 2025-03-02T18:05:29Z

I've updated noon (12:00) to 13:00 to reduce any possible confusion between AM and PM and I've made ASAP use before and after or at (which was previously unspecified). Maybe one final check?

IsaacG · 2025-03-02T18:20:41Z

I've updated noon (12:00) to 13:00 to reduce any possible confusion between AM and PM and I've made ASAP use before and after or at (which was previously unspecified). Maybe one final check?

https://gist.github.com/IsaacG/e7e628532af521a505b3336ee0a09458

My updated solution seems to work fine with the test data.

ErikSchierboom · 2025-03-02T19:05:49Z

Just needs two approvals then 🙂

BethanyG · 2025-03-02T21:35:29Z

Just needs two approvals then 🙂

It would appear that it needs maintainers-admin (codeowners).
Python implementation here: exercism/python#3876

I might have the Python version return the delivery dates in a format different from the input ISO, in order to have a little practice with datetime.strftime() and its format codes. Still pondering that.

Also wondering if it would be rude to include leap year scenarios or not.....

ErikSchierboom · 2025-03-03T07:38:28Z

I might have the Python version return the delivery dates in a format different from the input ISO, in order to have a little practice with datetime.strftime() and its format codes. Still pondering that.

That sounds totally reasonable.

Also wondering if it would be rude to include leap year scenarios or not.....

Not at all. I'll add such a test case.

ErikSchierboom · 2025-03-03T07:46:17Z

@BethanyG I've added a test case for a leap day: 2a5a746 Could someone verify its correctness?

BethanyG · 2025-03-03T18:23:55Z

Apologies for the delay, @ErikSchierboom -- test case validated. 😄

exercism/python#3876

ErikSchierboom · 2025-03-03T18:41:47Z

No problem. Thanks for the validation

Add swift-scheduling exercise

964b868

ErikSchierboom requested a review from a team as a code owner March 1, 2025 13:43

tasxatzial reviewed Mar 1, 2025

View reviewed changes

ErikSchierboom and others added 6 commits March 1, 2025 16:56

Update introduction.md

0f7017a

Co-authored-by: Anastasios Chatzialexiou <[email protected]>

Update instructions.md

e9ed1e7

Co-authored-by: Anastasios Chatzialexiou <[email protected]>

Update instructions.md

193d3b2

Co-authored-by: Anastasios Chatzialexiou <[email protected]>

Update instructions.md

6e16f19

Co-authored-by: Anastasios Chatzialexiou <[email protected]>

Update instructions.md

cf93143

Co-authored-by: Anastasios Chatzialexiou <[email protected]>

Update instructions.md

7251584

Co-authored-by: Anastasios Chatzialexiou <[email protected]>

IsaacG approved these changes Mar 1, 2025

View reviewed changes

ErikSchierboom added 2 commits March 1, 2025 20:01

Fix formatting

d88ffc0

Add instructions for quarter and month

338fc9c

BethanyG approved these changes Mar 1, 2025

View reviewed changes

Add test cases

f48d397

ErikSchierboom added 3 commits March 1, 2025 20:32

Fix duplicate uuid

8e6a8c5

Fix HTML

6d7a4b9

Explain quarters

83b52b4

IsaacG reviewed Mar 1, 2025

View reviewed changes

exercises/swift-scheduling/canonical-data.json Outdated Show resolved Hide resolved

exercises/swift-scheduling/canonical-data.json Show resolved Hide resolved

IsaacG reviewed Mar 1, 2025

View reviewed changes

ErikSchierboom added 4 commits March 2, 2025 08:52

Minor tweak to quarters

1bf08ed

Fix iso date

7f6b1aa

Fix data

dd71883

Fix eow

74bf189

angelikatyborska reviewed Mar 2, 2025

View reviewed changes

Update noon to 13:00

2999e76

IsaacG approved these changes Mar 2, 2025

View reviewed changes

BNAndras approved these changes Mar 2, 2025

View reviewed changes

BethanyG mentioned this pull request Mar 3, 2025

[Swift Scheduling]: Added Files for New Practice Exercise exercism/python#3876

Draft

Add leap day test case

2a5a746

ErikSchierboom merged commit a8ca9c5 into main Mar 3, 2025
7 checks passed

ErikSchierboom deleted the swift-scheduling branch March 3, 2025 18:05

ErikSchierboom mentioned this pull request Mar 3, 2025

Add icon for swift-scheduling exercise exercism/website-icons#190

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `swift-scheduling` exercise #2536

Add `swift-scheduling` exercise #2536

ErikSchierboom commented Mar 1, 2025

tasxatzial left a comment

IsaacG Mar 1, 2025

ErikSchierboom Mar 1, 2025

ErikSchierboom Mar 1, 2025

ErikSchierboom Mar 1, 2025

ErikSchierboom commented Mar 1, 2025

BethanyG commented Mar 1, 2025

IsaacG Mar 1, 2025

IsaacG Mar 1, 2025

ErikSchierboom Mar 2, 2025

IsaacG Mar 1, 2025

ErikSchierboom Mar 2, 2025

IsaacG commented Mar 1, 2025

ErikSchierboom commented Mar 2, 2025

angelikatyborska Mar 2, 2025

ErikSchierboom Mar 2, 2025

angelikatyborska Mar 2, 2025

ErikSchierboom Mar 2, 2025

ErikSchierboom Mar 2, 2025

angelikatyborska commented Mar 2, 2025

IsaacG commented Mar 2, 2025

ErikSchierboom commented Mar 2, 2025

IsaacG commented Mar 2, 2025

ErikSchierboom commented Mar 2, 2025

BethanyG commented Mar 2, 2025 •

edited

Loading

ErikSchierboom commented Mar 3, 2025

ErikSchierboom commented Mar 3, 2025

BethanyG commented Mar 3, 2025

ErikSchierboom commented Mar 3, 2025

		\| `"ASAP"` \| Before 12:00 \| Today at 17:00 \|
		\| `"ASAP"` \| After 12:00 \| Tomorrow at 12:00 \|

Add swift-scheduling exercise #2536

Add swift-scheduling exercise #2536

Conversation

ErikSchierboom commented Mar 1, 2025

tasxatzial left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ErikSchierboom commented Mar 1, 2025

BethanyG commented Mar 1, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IsaacG commented Mar 1, 2025

ErikSchierboom commented Mar 2, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

angelikatyborska commented Mar 2, 2025

IsaacG commented Mar 2, 2025

ErikSchierboom commented Mar 2, 2025

IsaacG commented Mar 2, 2025

ErikSchierboom commented Mar 2, 2025

BethanyG commented Mar 2, 2025 • edited Loading

ErikSchierboom commented Mar 3, 2025

ErikSchierboom commented Mar 3, 2025

BethanyG commented Mar 3, 2025

ErikSchierboom commented Mar 3, 2025

Add `swift-scheduling` exercise #2536

Add `swift-scheduling` exercise #2536

BethanyG commented Mar 2, 2025 •

edited

Loading