Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of the clock exercise #19

Merged
merged 9 commits into from
Nov 1, 2023

Conversation

BNAndras
Copy link
Member

No description provided.

@BNAndras BNAndras added x:rep/small Small amount of reputation x:module/practice-exercise Work on Practice Exercises x:size/small Small amount of work x:type/content Work on content (e.g. exercises, concepts) labels Jun 29, 2023
@BNAndras BNAndras requested a review from BethanyG June 29, 2023 03:55
@BNAndras
Copy link
Member Author

@BethanyG, would you mind doing a quick gut check on if I over-complicated this exercise? Using a data declaration for Clock seems a good fit here, especially once we have a syllabus to properly introduce it At the moment, it feels a big step up from previous exercises I drafted.

@BethanyG
Copy link
Member

Will add it to my list! IIRC, we had a similar issue in Python, where Clock required a class with all sorts of methods - including a __repr__ and a __str__ (with or without optional composition from datetime). We had to add an instruction append by way of explanation.

We could do that here, referencing docs or going into the related concepts -- but let me get a quiet moment to really look at it. 😄

@BNAndras
Copy link
Member Author

Ooh, that's a great idea. An instruction append would go a long way with the D&D Character exercise I was asking about in Discord earlier.

@BNAndras
Copy link
Member Author

Since we're at 20+ exercises for launch, this review can be low priority, @BethanyG. Thanks for your help so far with the track.

@BNAndras BNAndras self-assigned this Jul 24, 2023
@BNAndras BNAndras closed this Aug 3, 2023
@BNAndras BNAndras force-pushed the add-clock-exercise branch 2 times, most recently from 0a0a897 to bbdd935 Compare August 3, 2023 03:03
@BNAndras BNAndras reopened this Aug 3, 2023
@BNAndras BNAndras marked this pull request as draft August 3, 2023 03:09
@BNAndras
Copy link
Member Author

BNAndras commented Aug 3, 2023

It seems I can define an _equals method (https://pyret.org/docs/latest/equality.html#%28part._equality__equals%29) that Pyret will use to check equality. That might be a better approach than then manual values-equal implementation so I'll play with this a little and see if it's more flexible. That'll likely require bumping up the exercise difficulty.

@BNAndras BNAndras added x:rep/medium Medium amount of reputation and removed x:rep/small Small amount of reputation x:size/small Small amount of work labels Aug 15, 2023
@BNAndras BNAndras marked this pull request as ready for review September 12, 2023 20:42
@BNAndras BNAndras merged commit ce81761 into exercism:main Nov 1, 2023
2 checks passed
@BNAndras BNAndras deleted the add-clock-exercise branch November 1, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:module/practice-exercise Work on Practice Exercises x:rep/medium Medium amount of reputation x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants