Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flatten-array #51

Merged
merged 7 commits into from
Nov 1, 2023
Merged

Add flatten-array #51

merged 7 commits into from
Nov 1, 2023

Conversation

BNAndras
Copy link
Member

@BethanyG, this is another one for your review, but it's not a priority since we have enough exercises for launch.

I set this up using lists for simplicity, but I'm thinking the exercise could benefit from having the students deal with mutable [arrays][https://pyret.org/docs/latest/arrays.html] instead. We don't have any exercises yet that lend themselves to an array since lists are more versatile. If we swap to arrays, a student can still use lists internally as long as they convert the list back to an array at the end. If they use arrays, they'd likely need a [for loop[https://pyret.org/docs/latest/A_Tour_of_Pyret.html#%28part._.For_loops%29] which might bump up the difficulty. Either way, we'll want an instructions append to clarify to students what we're expecting since the instructions reference lists in an exercise whose name references arrays.

@BNAndras BNAndras added x:size/tiny Tiny amount of work x:module/practice-exercise Work on Practice Exercises x:rep/tiny Tiny amount of reputation x:type/content Work on content (e.g. exercises, concepts) x:knowledge/none No existing Exercism knowledge required labels Jul 24, 2023
@BNAndras BNAndras requested a review from BethanyG July 24, 2023 04:53
@BNAndras BNAndras self-assigned this Jul 24, 2023
@BNAndras BNAndras added x:rep/large Large amount of reputation and removed x:size/tiny Tiny amount of work x:rep/tiny Tiny amount of reputation labels Aug 15, 2023
@BNAndras BNAndras marked this pull request as ready for review September 6, 2023 00:40
@BNAndras BNAndras merged commit 5314686 into exercism:main Nov 1, 2023
@BNAndras BNAndras deleted the add-flatten-array branch November 1, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:knowledge/none No existing Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants