Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reverse String #1623

Merged
merged 6 commits into from
Jan 27, 2024
Merged

Add Reverse String #1623

merged 6 commits into from
Jan 27, 2024

Conversation

iHiD
Copy link
Member

@iHiD iHiD commented Jan 24, 2024

I wasn't sure on the best module name. Do we have a standard we use for Practice Exercises?

@iHiD iHiD requested review from kotp and ErikSchierboom January 24, 2024 22:06
@ErikSchierboom
Copy link
Member

rubocop is complaining

@kotp
Copy link
Member

kotp commented Jan 25, 2024

There are only two practice exercises that look like this:

exercises/practice/reverse-string/.meta
├── config.json                        
├── solutions                          
│   └── reverse_string.rb              
└── tests.toml                         

The rest of them look like:

exercises/practice/accumulate/.meta
├── config.json                    
├── example.rb                     
└── tests.toml                     

@iHiD
Copy link
Member Author

iHiD commented Jan 26, 2024

@kotp Thanks. Fixed here and updated for the long-term fix here: #1628

Please merge if you're happy with this :)

@@ -4,13 +4,13 @@
],
"files": {
"solution": [
"reverse_string.rb"
"reverser.rb"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally speaking, though it is not always the case, the file name has matched the slug of the exercise (with the exception of the - being _ when representing two words.

@@ -1,4 +1,4 @@
module ReverseString
module Reverser
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

@kotp
Copy link
Member

kotp commented Jan 26, 2024

@kotp Thanks. Fixed here and updated for the long-term fix here: #1628

Please merge if you're happy with this :)

The file name change that is a bit more than a approve/like/merge. It speaks to "convention" from the Exercism viewpoint. So, I would like to confirm with you that the difference (though it does happen) in the naming style is also fine with @ErikSchierboom as well as you.

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@kotp kotp merged commit c594059 into main Jan 27, 2024
4 checks passed
@kotp kotp deleted the reverse-string branch January 27, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants