-
-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Reverse String #1623
Add Reverse String #1623
Conversation
exercises/practice/reverse-string/.meta/solutions/reverse_string.rb
Outdated
Show resolved
Hide resolved
rubocop is complaining |
There are only two practice exercises that look like this:
The rest of them look like:
|
@@ -4,13 +4,13 @@ | |||
], | |||
"files": { | |||
"solution": [ | |||
"reverse_string.rb" | |||
"reverser.rb" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally speaking, though it is not always the case, the file name has matched the slug of the exercise (with the exception of the -
being _
when representing two words.
@@ -1,4 +1,4 @@ | |||
module ReverseString | |||
module Reverser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it.
The file name change that is a bit more than a approve/like/merge. It speaks to "convention" from the Exercism viewpoint. So, I would like to confirm with you that the difference (though it does happen) in the naming style is also fine with @ErikSchierboom as well as you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
I wasn't sure on the best module name. Do we have a standard we use for Practice Exercises?