Add spiral matrix exercise #1636
Conversation
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
| class SpiralMatrix | ||
| def initialize | ||
| # Your code here | ||
| end |
There was a problem hiding this comment.
I have a preference not to have methods defined in stubs with the wrong signatures (e.g. here initialize needs to take a size). And equally, I'd rather not force the implementation by having a param defined, so I think my preference is just to remove this method and the the one below.
But please tell me if there's a specific reason you felt they would be good to include.
There was a problem hiding this comment.
This was how I'd been asked to implement it in the Dnd Character exercise PR, was copying here, but happy to change whatever!
There was a problem hiding this comment.
Yeah, I think you should remove the code and just leave the comment at the top please. That's how all the other practice exercises are implemented (e.g. https://github.com/exercism/ruby/blob/main/exercises/practice/binary-search/binary_search.rb :)
There was a problem hiding this comment.
I think it was a focus on providing a comment so that we did not submit an empty file. Leave the practice exercises as mostly unguided.
ccadden
force-pushed
the
add-spiral-matrix-exercise
branch
from
a5a30d6 to
290d31b
Compare
|
|
||
| To get started with TDD, see the `README.md` file in your | ||
| `ruby/spiral-matrix` directory. | ||
| =end |
Co-authored-by: KOTP <[email protected]>
Co-authored-by: Victor Goff <[email protected]>
ccadden
force-pushed
the
add-spiral-matrix-exercise
branch
from
e507bef to
5c86451
Compare
|
Looking good! Thank you @Mr-sigma |
Forum thread: https://forum.exercism.org/t/add-spiral-matrix-exercise/9795
Ran into some issues with Rubocop's ABC complexity for generating the matrix, as well as it being unhappy with using
attr_readerin some cases so would be interested in feedback for the example solution, but don't need it to be a blocker for getting the code in!