Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generator: add filter for snake_case #1887

Merged
merged 14 commits into from
Apr 2, 2024
Merged

generator: add filter for snake_case #1887

merged 14 commits into from
Apr 2, 2024

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Apr 1, 2024

No description provided.

senekor added 13 commits March 30, 2024 23:22
The logic to extract the function names from the lib.rs stub to use it
for exercise generation doesn't really add any value, it just makes
things more complicated. First of all, the Rust code itself.
But also the tera templates, which contain a {{ fn_names[0] }}.

All for saving a few characters of typing when creating a new template.
That's not worth it in my opinion. The templating context should only
contain things that actually change dynamically, namely the test data.
@senekor
Copy link
Contributor Author

senekor commented Apr 1, 2024

The full diff is a bit noisy because all the templates changed. The interesting changes are on commit 4bbce68, the repetitive bits are on 075e4c8.

@senekor senekor requested a review from ErikSchierboom April 1, 2024 08:19
Base automatically changed from clean-context to main April 2, 2024 07:54
@senekor senekor merged commit 8d89b31 into main Apr 2, 2024
10 checks passed
@senekor senekor deleted the custom-filters branch April 2, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants