circular-buffer: sync #1893
Merged
circular-buffer: sync #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
senekor
force-pushed
the
circular-buffer-sync
branch
from
0ec1a83 to
76c7b5b
Compare
senekor
commented
Apr 2, 2024
Comment on lines
+33
to
+61
| {#- | ||
| We usually do not add additional tests directly in the template. | ||
| In this case however, the structure of the tests is different from the | ||
| regular ones. Accommodating that in the template would be complicated | ||
| and unnecessary. | ||
| #} | ||
|
|
||
| #[test] | ||
| #[ignore] | ||
| fn clear_actually_frees_up_its_elements() { | ||
| let mut buffer = CircularBuffer::new(1); | ||
| let element = Rc::new(()); | ||
| assert!(buffer.write(Rc::clone(&element)).is_ok()); | ||
| assert_eq!(Rc::strong_count(&element), 2); | ||
| buffer.clear(); | ||
| assert_eq!(Rc::strong_count(&element), 1); | ||
| } | ||
|
|
||
| #[test] | ||
| #[ignore] | ||
| fn dropping_the_buffer_drops_its_elements() { | ||
| let element = Rc::new(()); | ||
| { | ||
| let mut buffer = CircularBuffer::new(1); | ||
| assert!(buffer.write(Rc::clone(&element)).is_ok()); | ||
| assert_eq!(Rc::strong_count(&element), 2); | ||
| } | ||
| assert_eq!(Rc::strong_count(&element), 1); | ||
| } |
ErikSchierboom
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[no important files changed]