Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generator: replace snake_case with make_ident #1969

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Aug 15, 2024

[no important files changed]

@senekor
Copy link
Contributor Author

senekor commented Aug 15, 2024

A lot of template files changed here, but the output generally stays the same. A couple actual test files changed (only the names of the test functions), the diff is here.

@senekor
Copy link
Contributor Author

senekor commented Aug 15, 2024

I noticed that the "no important files changed" workflow didn't do its job here. Wild guess: it doesn't work because there are multiple test files changed. In the workflow, this line will be executed multiple times:

echo "important_files_changed=${changed}" >> "$GITHUB_OUTPUT"

So the variable GITHUB_OUTPUT is defined multiple times? I adon't know how github handles this, it may do something random like concatinate all values with commas or similar. If that was the case, the following check won't work anymore:

steps.check.outputs.important_files_changed == 'true'

EDIT: I checked an I was wrong. It generally works with multiple changes as well:
#1971

So, I don't know why it didn't work this time.

@senekor senekor requested a review from ErikSchierboom August 15, 2024 07:31
@senekor senekor merged commit f0cfd47 into main Aug 15, 2024
12 checks passed
@senekor senekor deleted the remo/unlqvrppkkwz branch August 15, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants