exercises(roman-numerals): implement #383
Conversation
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
mk2s
force-pushed
the
adding-roman-numerals
branch
from
ee80e01
to
7e42b1f
Compare
|
Thanks. I'll try to look at this in the next day or two. |
mk2s
force-pushed
the
adding-roman-numerals
branch
from
7e42b1f
to
ce652af
Compare
| }; | ||
|
|
||
| pub fn toRoman(allocator: mem.Allocator, arabicNumeral: i16) mem.Allocator.Error![]u8 { | ||
| var tmp: [10]u8 = undefined; |
There was a problem hiding this comment.
3888 has 3 + 4 + 4 + 4 digits. Perhaps change the 10 to 15
this is my first PR, I did my best to follow the instructions.