resolve comments

experimental-design · Nov 30, 2023 · 5ce8d3e · 5ce8d3e
1 parent 5800d05
commit 5ce8d3e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/bofire/data_models/constraints/constraint.py b/bofire/data_models/constraints/constraint.py
@@ -53,6 +53,10 @@ def jacobian(self, experiments: pd.DataFrame) -> pd.DataFrame:
 
 
 class IntrapointConstraint(Constraint):
+    """An intrapoint constraint describes required relationships within a candidate
+    when asking a strategy to return one or more candidates.
+    """
+
     type: str
 
 

diff --git a/bofire/utils/torch_tools.py b/bofire/utils/torch_tools.py
@@ -91,7 +91,9 @@ def get_interpoint_constraints(
     domain: Domain, n_candidates: int
 ) -> List[Tuple[Tensor, Tensor, float]]:
     """Converts interpoint equality constraints to linear equality constraints,
-        that can be processed by botorch.
+        that can be processed by botorch. For more information, see the docstring
+        of `optimize_acqf` in botorch
+        (https://github.com/pytorch/botorch/blob/main/botorch/optim/optimize.py).
 
     Args:
         domain (Domain): Optimization problem definition.

diff --git a/tests/bofire/data_models/specs/constraints.py b/tests/bofire/data_models/specs/constraints.py
@@ -51,6 +51,6 @@
     constraints.InterpointEqualityConstraint,
     lambda: {
         "feature": "f1",
-        "multiplicity": 1,
+        "multiplicity": 3,
     },
 )