Skip to content

Commit

Permalink
[BUGFIX] UI xml argument: name="context" xsi:type="configurableObject…
Browse files Browse the repository at this point in the history
…" breaks adminhtml in Magento 2.3.3.

[FEATURE] Removed redundant commented out xml in UI xml declaration for mass action.
[FEATURE] Sort order changed to be a tad more logical in the adminhtml overview.
[FEATURE] Removed "id" selection column, since no actions are present.
  • Loading branch information
Boris van Katwijk committed Oct 8, 2019
1 parent 41334f3 commit edb3293
Showing 1 changed file with 4 additions and 36 deletions.
40 changes: 4 additions & 36 deletions view/adminhtml/ui_component/experius_emailcatcher_index.xml
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
<?xml version="1.0" ?>
<listing xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Ui:etc/ui_configuration.xsd">
<argument name="context" xsi:type="configurableObject">
<argument name="class" xsi:type="string">Magento\Framework\View\Element\UiComponent\Context</argument>
<argument name="namespace" xsi:type="string">experius_emailcatcher_index</argument>
</argument>
<argument name="data" xsi:type="array">
<item name="js_config" xsi:type="array">
<item name="provider" xsi:type="string">experius_emailcatcher_index.experius_emailcatcher_grid_data_source</item>
Expand All @@ -15,7 +11,6 @@
<item name="name" xsi:type="string">cleanup</item>
<item name="label" translate="true" xsi:type="string">Run Cleanup</item>
<item name="url" xsi:type="string">*/*/cleanup</item>
<!--<item name="on_click" xsi:type="string">deleteConfirm('Are you sure you want to do this?')</item>-->
</item>
</item>
</argument>
Expand Down Expand Up @@ -45,26 +40,6 @@
<bookmark name="bookmarks"/>
<columnsControls name="columns_controls"/>
<filters name="listing_filters"/>
<massaction name="listing_massaction" component="Magento_Ui/js/grid/tree-massactions">
<!--<action name="forward">-->
<!--<settings>-->
<!--<url path="*/*/forward"/>-->
<!--<type>forward</type>-->
<!--<label translate="true">Forward</label>-->
<!--</settings>-->
<!--</action>-->
<!--<action name="delete">-->
<!--<settings>-->
<!--<confirm>-->
<!--<message translate="true">Delete selected items?</message>-->
<!--<title translate="true">Delete items</title>-->
<!--</confirm>-->
<!--<url path="*/*/massDelete"/>-->
<!--<type>delete</type>-->
<!--<label translate="true">Delete</label>-->
<!--</settings>-->
<!--</action>-->
</massaction>
<paging name="listing_paging"/>
</listingToolbar>
<columns name="experius_emailcatcher_columns">
Expand All @@ -82,13 +57,6 @@
</item>
</item>
</argument>
<selectionsColumn name="ids">
<argument name="data" xsi:type="array">
<item name="config" xsi:type="array">
<item name="indexField" xsi:type="string">emailcatcher_id</item>
</item>
</argument>
</selectionsColumn>
<column name="emailcatcher_id">
<argument name="data" xsi:type="array">
<item name="config" xsi:type="array">
Expand All @@ -98,11 +66,11 @@
</item>
</argument>
</column>
<column name="recipient">
<column name="subject">
<argument name="data" xsi:type="array">
<item name="config" xsi:type="array">
<item name="filter" xsi:type="string">text</item>
<item name="label" translate="true" xsi:type="string">To</item>
<item name="label" translate="true" xsi:type="string">Subject</item>
</item>
</argument>
</column>
Expand All @@ -114,11 +82,11 @@
</item>
</argument>
</column>
<column name="subject">
<column name="recipient">
<argument name="data" xsi:type="array">
<item name="config" xsi:type="array">
<item name="filter" xsi:type="string">text</item>
<item name="label" translate="true" xsi:type="string">Subject</item>
<item name="label" translate="true" xsi:type="string">To</item>
</item>
</argument>
</column>
Expand Down

0 comments on commit edb3293

Please sign in to comment.