Unstuck car implementation #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the entity name used to find a non-colliding position to assembling-machine-1. This moves the car away from close obstacles it could get stuck in due to the non-colliding position algorithm not taking account to the rotation of the car.
Add unstuck command for the Race game which moves the player's car away from nearby obstacles.
Fix the commands part of mini-games not being disabled when the game is over.
| --- Respawn the car for a player | ||
| local respawn_car | ||
| respawn_car = Token.register(function(name) | ||
| local player = dead_cars[name].player | ||
| local position = surface[1].find_non_colliding_position('car', dead_cars[name].position, 5, 0.5) | ||
| local position = surface[1].find_non_colliding_position('assembling-machine-1', dead_cars[name].position, 5, 0.5) |
There was a problem hiding this comment.
mabye just use smt like rocket silo so you dont need the command at all
There was a problem hiding this comment.
Rocket silo is 9x9. That would make it fail in narrow sections and is completely unacceptable. And even so, it's still possible to get pretty stuck driving parallel to a straight section of wall so you still need the command anyhow.
There was a problem hiding this comment.
The assembling seams like the right choice as its about the same size as a car but without the rotational difference.
Pass the missing car error message to Command.error and let the command system print it to the user.
tovernaar123
approved these changes
Aug 26, 2020
Cooldude2606
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to using an assembly machine as the name for the find_non_colliding_possition call. This will make it use a larger bounding box for checking collisions and thereby place the car some distance away from the wall.
Implement /unstuck command as detailed in #51. No GUI since I'm not sure how to do that properly. The command might be a bit abusable as it generally places you some distance away from your current position, so if you collide into an obstacle and use it you get put left or right from your current position and could probably start driving immediately. Same goes for escaping a biter swarm with it.