Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to sentry-react-native 5.10.0 and sentry-javascript 7.69.0 #374

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

krystofwoldrich
Copy link
Contributor

@krystofwoldrich krystofwoldrich commented Oct 4, 2023

Checklist

Why

Customers having this issue have to manually upgrade the cli at the moment.

@ceafive
Copy link

ceafive commented Oct 6, 2023

Can we get this merged?

@sergey-king
Copy link

Can we get this merged?

+1

@szt217
Copy link

szt217 commented Oct 10, 2023

+1. Can we get this merged, please? My team could use this update.

@victoralmeidadev
Copy link

Can we get this merged?

+1

@raphaelm-gioa
Copy link

Hi, I see this being ready and not merged, bumping 😊 thanks

@sergey-king
Copy link

@brentvatne anyone from the sentry team can look at this? We'd love to get this merge

@rflukes
Copy link

rflukes commented Oct 18, 2023

+1, would love to get this merged

@brentvatne brentvatne merged commit 97a91c2 into expo:main Oct 19, 2023
2 checks passed
@brentvatne
Copy link
Member

please install [email protected] to get the version with this patch applied. once you have done so, please report back to verify that everything is working well in your app. if a few folks report back success, i'll go ahead and promote this to the default version for sdk 49

@SimenB
Copy link
Contributor

SimenB commented Oct 19, 2023

Supersedes #358

@joeporpeglia
Copy link

joeporpeglia commented Oct 23, 2023

@brentvatne after upgrading to [email protected] and @sentry/[email protected] it looks like source maps are uploaded for both ios and android. , but stack traces aren't being mapped correctly. When I run sentry-cli sourcemaps explain it says Event exception stacktrace selected frame (0) has incorrect abs_path (valid url is required).

Both ios and android builds were done through EAS - I can provide a link to the builds if that's helpful.

Edit: Everything does seem to be working as expected! The issue I redacted was unrelated. We have a dependency that loads and runs additional JS outside the RN bundle. That JS was throwing an error and it just happened to be the first few events that came into Sentry for this release.

@Arashadmin
Copy link

Arashadmin commented Dec 12, 2023

Hi! I'm a bit confused again :/

I'm using [email protected] and @sentry/[email protected] in order to get rid of this issue here
).

But as I can see here, [email protected] is only compatible with @sentry/[email protected] ? I'm saying this, because my staging app is directly crashing after launching the app.
Am I correct?
Do you know when it'll be compatible with @sentry/[email protected] where I can find the fix for my specific issue?

Thanks for your reply!
Ari

@krystofwoldrich
Copy link
Contributor Author

Hello @Arashadmin ,
@sentry/react-native now supports Expo out of the box!

Update to https://github.com/getsentry/sentry-react-native/releases/tag/5.16.0 or newer to get all the new features.

Migration guides available:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.