Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add userAgent query parameter in debugger #237

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Dec 2, 2023

Linked issue

See PR expo/expo#25649, specifically this line

Additional context

VSCode doesn't send any User-Agent headers when connecting through web sockets. This differs from the Chrome DevTools, where we can safely detect this Chrome-based debugger. Since we have some workarounds for known React Native CDP (as opposed to the future Hermes CDP) implementation.

TODO

@byCedric byCedric marked this pull request as draft December 2, 2023 13:14
@byCedric byCedric marked this pull request as ready for review March 6, 2024 15:33
@byCedric byCedric merged commit 7c978e5 into main Mar 6, 2024
@byCedric byCedric deleted the fix/add-user-agent branch March 6, 2024 15:33
expo-bot pushed a commit that referenced this pull request Mar 6, 2024
## [1.2.2](1.2.1...1.2.2) (2024-03-06)

### Bug fixes

* add `userAgent` query parameter in debugger ([#237](#237)) ([7c978e5](7c978e5))
* bump `@vscode/test-electron` to `2.3.9` ([913cb7f](913cb7f))
* only change to underlying vscode adapter when starting debug session ([#245](#245)) ([7a3190f](7a3190f)), closes [microsoft/vscode#188979](microsoft/vscode#188979)

### Other chores

* bump @babel/traverse from 7.22.11 to 7.23.2 ([#233](#233)) ([2047870](2047870))
* bump @babel/traverse from 7.22.11 to 7.23.2 in /test/fixture ([#232](#232)) ([51d7292](51d7292))
* bump postcss from 8.4.29 to 8.4.31 in /test/fixture ([#230](#230)) ([a3ecf90](a3ecf90))
* bump react-devtools-core from 4.28.0 to 4.28.4 in /test/fixture ([#234](#234)) ([747d308](747d308))
* **ci:** rotate and update repository secrets ([#236](#236)) ([3fba51a](3fba51a))
@expo-bot
Copy link
Contributor

expo-bot commented Mar 6, 2024

🎉 This PR is included in version 1.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants