Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deps to latest versions and replace var with const/let #35

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from

Conversation

carpasse
Copy link
Contributor

Refs: #25

const markdown = require('eslint-plugin-markdown')

module.exports = [
...neostandard({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to migrate to neostandard because standard does not support eslint 9

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @ctcpip @wesleytodd I know that there is long discussion on going about linters, can you confirm if we are align with your proposal for the "near future"? 🙏

{
languageOptions: {
// See https://compat-table.github.io/compat-table/es2016plus/#node18_3
ecmaVersion: 2022,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing this compatibility table, it looks like Node.js v18 fully supports ECMAScript 2022, with only a couple of RegExp flags not fully implemented.

Let me know if you think we should target a lower ECMAScript version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is fine 👍

@@ -39,7 +41,7 @@
"node": ">= 18"
},
"scripts": {
"lint": "eslint --plugin markdown --ext js,md .",
"lint": "eslint --flag unstable_config_lookup_from_file .",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only way I found to add the needed config for tests. This flag enables the new lookup behaviour starting in eslint v10.0.0,

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should fix the CI issues: #36 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants