CVPN-1554 Remove liboqs and use WolfSSL's implementations #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kp-thomas-yau
changed the title
|
Code coverage summary for 134071a: ✅ Region coverage 59% passes |
kp-thomas-yau
force-pushed
the
CVPN-1554-remove-liboqs-and-use-new-wolfssl
branch
from
b5a6004 to
1a2ebf2
Compare
kp-thomas-yau
force-pushed
the
CVPN-1554-remove-liboqs-and-use-new-wolfssl
branch
3 times, most recently
from
b6c883c to
f6f46c1
Compare
kp-thomas-yau
force-pushed
the
CVPN-1554-remove-liboqs-and-use-new-wolfssl
branch
from
f6f46c1 to
f651f99
Compare
There was a problem hiding this comment.
Can you please add context around this renaming and removal of the part of the patch ?
There was a problem hiding this comment.
I have replaced the patch with their PR fix: wolfSSL/wolfssl#8196
Since now we are removing liboqs, HAVE_LIBOQS would not be defined and the patch in settings.h would not be compiled anyway.
kp-thomas-yau
force-pushed
the
CVPN-1554-remove-liboqs-and-use-new-wolfssl
branch
from
f651f99 to
9b0c980
Compare
Remove liboqs and enable WolfSSL's own Kyber implementation via the flags. See: wolfSSL/wolfssl#8183
We would use a patch to use WolfSSL's implementation of both Kyber and ML-KEM so that we can remove liboqs while maintaining support for Kyber at the moment. This patch uses commits and code changes from the following PR in WolfSSL: - wolfSSL/wolfssl#8143 - wolfSSL/wolfssl#8172 - wolfSSL/wolfssl#8183 - wolfSSL/wolfssl#8185
Disable dilithium explicitly so that we can reduce WolfSSL size as we are not using it at the moment.
Use the official fix from WolfSSL PR: wolfSSL/wolfssl#8196 instead of our own implementation to enable private key fields in key share entry when we are using post-quantum KEM.
kp-thomas-yau
force-pushed
the
CVPN-1554-remove-liboqs-and-use-new-wolfssl
branch
from
9b0c980 to
ab01e98
Compare
kp-mariappan-ramasamy
approved these changes
Nov 18, 2024
kp-thomas-yau
deleted the
CVPN-1554-remove-liboqs-and-use-new-wolfssl
branch
kp-thomas-yau
added a commit
that referenced
this pull request
Nov 18, 2024
Add relevant tests and different ML-KEM groups to be used in the Lightway. The config flags can be found here: #192
kp-thomas-yau
added a commit
that referenced
this pull request
Nov 18, 2024
Add relevant tests and different ML-KEM groups to be used in the Lightway. The config flags can be found here: #192
kp-thomas-yau
added a commit
that referenced
this pull request
Nov 18, 2024
Add relevant tests and different ML-KEM groups to be used in the Lightway. The config flags can be found here: #192
kp-thomas-yau
added a commit
that referenced
this pull request
Nov 18, 2024
Add relevant tests and different ML-KEM groups to be used in the Lightway. The config flags can be found here: #192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
liboqsand would instead use WolfSSL's implementation of Kyber. Since WolfSSL would officially release their Kyber/ML-KEM implementations a few months later, we would use the git patch to essentially patch their PRs on top of the 5.7.4 release.The patch consists of the commits and code changes from the following PR from WolfSSL:
Configuration for enabling ML-KEM/Kyber:
./configure --enable-kyber
./configure --enable-kyber=all,ml-kem
./configure --enable-kyber=all,original
./configure --enable-kyber=all,original,ml-kem
./configure --enable-kyber=all,ml-kem,original
Testing
Tested with helium-cli, lightway clients (with and without liboqs)
See: https://polymoon.atlassian.net/browse/CVPN-1554?focusedCommentId=1351477
CI pipelines for
kp_lightway,lightwaypassed as wellhttps://github.com/expressvpn/lightway/pull/122