build(deps): Bump d3 to 3.0.0 (#311)

extenda · Aug 9, 2024 · a0c6f6a · a0c6f6a
1 parent 1577a44
commit a0c6f6a
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 19 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/app/jest.config.js b/packages/app/jest.config.js
@@ -7,6 +7,8 @@ module.exports = {
   moduleNameMapper: {
     '\\.(css|less)$': 'identity-obj-proxy',
     'react-markdown': '<rootDir>/../../node_modules/react-markdown/react-markdown.min.js',
+    'd3-selection': '<rootDir>/../../node_modules/d3-selection/dist/d3-selection.js',
+    'd3-force': '<rootDir>/../../node_modules/d3-force/dist/d3-force.js',
   },
   reporters: [
     'default',

diff --git a/packages/app/package.json b/packages/app/package.json
@@ -16,8 +16,8 @@
   "dependencies": {
     "@react-oauth/google": "^0.12.1",
     "@tech-radar/shared": "^0.0.0",
-    "d3-force": "^2.0.1",
-    "d3-selection": "^1.4.0",
+    "d3-force": "^3.0.0",
+    "d3-selection": "^3.0.0",
     "jwt-decode": "^4.0.0",
     "launchdarkly-react-client-sdk": "^3.4.0",
     "prop-types": "^15.7.2",

diff --git a/packages/app/src/js/lib/radar.js b/packages/app/src/js/lib/radar.js
@@ -152,7 +152,7 @@ export default class SvgRadar {
 
     const { print_layout } = this.config;
 
-    // Store all entries so we can search them by ID later.
+    // Store all entries, so we can search them by ID later.
     this.radarEntries = entries;
 
     this.rink.selectAll('*').remove();
@@ -210,9 +210,9 @@ export default class SvgRadar {
                 .text(d => `${d.id}. ${d.label}`)
                 .style('font-family', fontFamily)
                 .style('font-size', '10')
-                .on('mouseover', d => { this.showBubble(d); this.highlightLegendItem(d); })
-                .on('mouseout', d => { this.hideBubble(d); this.unhighlightLegendItem(d); })
-                .on('click', this.followLink);
+                .on('mouseover', (e, d) => { this.showBubble(d); this.highlightLegendItem(d); })
+                .on('mouseout', (e, d) => { this.hideBubble(d); this.unhighlightLegendItem(d); })
+                .on('click', (e, d) => this.followLink(d));
         }
       }
     }
@@ -223,9 +223,9 @@ export default class SvgRadar {
         .append('g')
           .attr('class', 'blip svglink')
           .attr('transform', (d, i) => this.legend_transform(d.quadrant, d.ring, i))
-          .on('mouseover', d => { this.showBubble(d); this.highlightLegendItem(d); })
-          .on('mouseout', d => { this.hideBubble(d); this.unhighlightLegendItem(d); })
-          .on('click', this.followLink);
+          .on('mouseover', (e, d) => { this.showBubble(d); this.highlightLegendItem(d); })
+          .on('mouseout', (e, d) => { this.hideBubble(d); this.unhighlightLegendItem(d); })
+          .on('click', (e, d) => this.followLink(d));
 
     // configure each blip
     blips.each(function (d) {
@@ -404,7 +404,7 @@ export default class SvgRadar {
   }
 
   showBubble = (d) => {
-    if (d.active || config.print_layout) {
+    if (d.active || this.config.print_layout) {
       let tooltip = d3.select('#bubble text')
         .text(d.label);
       let bbox = tooltip.node().getBBox();