Lint + tests fix

extension-js · Sep 3, 2024 · df46445 · df46445
1 parent efc286d
commit df46445
Show file tree

Hide file tree

Showing 4 changed files with 128 additions and 144 deletions.
diff --git a/programs/develop/commands/commands-lib/extract-from-zip.ts b/programs/develop/commands/commands-lib/extract-from-zip.ts
@@ -1,4 +1,3 @@
-import fs from 'fs/promises'
 import path from 'path'
 import axios from 'axios'
 import AdmZip from 'adm-zip'

diff --git a/programs/develop/webpack/plugin-extension/data/__spec__/manifest-fields/index.spec.ts b/programs/develop/webpack/plugin-extension/data/__spec__/manifest-fields/index.spec.ts
@@ -221,7 +221,8 @@ describe('getManifestFieldsData', () => {
         'images/my-image.png',
         'script.js',
         'styles.css'
-      ]
+      ],
+      locales: []
     })
   })
 

diff --git a/.../develop/webpack/plugin-extension/feature-scripts/steps/add-public-path-for-main-world.ts b/.../develop/webpack/plugin-extension/feature-scripts/steps/add-public-path-for-main-world.ts
@@ -1,4 +1,4 @@
-import type webpack from 'webpack'
+import {Compiler} from 'webpack'
 import {
   type FilepathList,
   type PluginInterface,
@@ -21,15 +21,15 @@ export class AddPublicPathForMainWorld {
     this.excludeList = options.excludeList || {}
   }
 
-  public apply(): void {
+  public apply(_compiler: Compiler): void {
     const manifest: Manifest = require(this.manifestPath)
     if (
       manifest.content_scripts?.some(
         // @ts-expect-error - TS doesn't know about content_scripts
         (cs) => cs.world && cs.world.toLowerCase() === 'main'
       )
     ) {
-      if (!CHROMIUM_BASED_BROWSERS.includes(this.browser) && manifest.key) {
+      if (CHROMIUM_BASED_BROWSERS.includes(this.browser) && !manifest.key) {
         console.error(messages.noExtensionIdError(manifest.name || ''))
         process.exit(1)
       }