-
Notifications
You must be signed in to change notification settings - Fork 358
include compound CSS selectors and those that don't mention the <svg> element #23
base: gh-pages
Are you sure you want to change the base?
Conversation
for example, "html body svg text {...}" becomes just "text {...}" so that it matches once the document is just the contents of the <svg>
e.g., `div, span {...}`
e.g., `body rect`
checking image.complete is required for some images
Safari blew up on `input[type="number"]::-webkit-inner-spin-button, input[type="number"]::-webkit-outer-spin-button`
'xlink:href' seems right, but doesn't work whereas 'href' works tested on Chrome, Safari, FF and IE10
More fixes have come up as I've been integrating this excellent library into our app. One fix was for an issue with Safari, another for inlined/cached images (which don't trigger |
At a glance, these changes look good, but I haven't yet had a chance to put together test scenarios to prevent regressions.
Thanks for the changes, as well as the cross-browser testing! |
Sorry, I should've been clearer.
LMK if you want me to help put together tests. I generally do lots of TDD. |
The tests for this library are in index.html, which creates a number of small test scenarios. You can see it here. In each pair of images, the one on the left is an SVG and the one on the right is the image produced by Before you start in, merge in the latest from the If you're not able to figure out the test file (it's a snowflake, I know), put together example scenarios demonstrating the problems or features, and I'll figure out how to integrate them into the tests. Thanks again for your effort on this, and sorry I've been so slow in responding. |
I think this solves the issues you pointed out in my last pull request.
Thanks again for this excellent software!