Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configured CMake to copy and update dists.dss #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adrianlut
Copy link

dbgen expects the dists.dss file inside its working directory. To facilitate out-of-source builds, CMake is now instructed to copy the file to the build folder where dbgen is located after compiling.

I also updated README.md and .gitignore to reflect this change.

dbgen expects the dists.dss file inside its working directory. To facilitate out-of-source builds, CMake is now instructed to copy the file to the build folder where dbgen is located after compiling.

Updated README and .gitignore to reflect this change.
@eyalroz
Copy link
Owner

eyalroz commented Jan 22, 2023

Why would dbgen be run with the working directory being the build directory?

@adrianlut
Copy link
Author

I think this change is mostly about defaults. As far as I know, out-of-source builds are generally considered good practice. Since dists.dss is a configuration file required at runtime, it belongs to the "distribution" of the runtime and therefore should be copied next to the compiled binary. In my opinion at least.

As to why dbgen would be run from within the build directory: this is just the default of my IDE and, as far as I know, it is also the default for other IDEs and languages, isn't it? Also, the compiled program depending on a file in the source tree seams weird to me.

Maybe the next change should be to change the default behavior of expecting the dists.dss file in the working directory to expecting it in the executable directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants