Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in authorization process #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bugs in authorization process #4

wants to merge 1 commit into from

Conversation

PopTo
Copy link
Contributor

@PopTo PopTo commented Jul 10, 2015

EyeEmAPI class:

  • implements singleton pattern (+defaultClient)
  • hides these methods that are useless as public (in authorization context)
  • removes -initWithClientId: method
  • removes -authorize: method
  • adds -authorizeWithClientId: method
  • changes the method name handleOpenURL: on parseAuthorizationURL:
  • fixes bugs in data processing for authorization process

EyeEmAPI class:
- implements singleton pattern (+defaultClient)
- hides these methods that are useless as public (in authorization context)
- removes -initWithClientId: method
- removes -authorize: method
- adds -authorizeWithClientId: method
- changes the method name handleOpenURL: on parseAuthorizationURL:
- fixes bugs in data processing for authorization process
@PopTo
Copy link
Contributor Author

PopTo commented Jul 10, 2015

Hi,
I have done first part of changes for authorization process. Can you review them?

Previously -authorize method don't works properly. I fixed that and I rebuild public interface for authorization process in EyeEmAPI class.

Best,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant